[PP-2] [FEATURE] Discus how to make JSON API use text input formats for long text fields

Awesome. Thanks for taking the time to contribute to the issue queue.

We shall see how the issue moves forward in core.

@dagmar the normalizer will always depend on the response format.

Can you share what the JSON response is with the patch in #2626924: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata applied?

Kicking the tests (I'll move back to needs work afterwards).

I like this approach #2 enough to proceed with it. We will need a test for it though.

Thanks for taking care of this!

+++ b/src/Normalizer/FieldItemNormalizer.php
@@ -29,9 +29,15 @@ class FieldItemNormalizer extends NormalizerBase {
+      $langcode = $context['langcode'];

Do we need to check if this value is set? I can't remember if there is a default.

Maybe you can add a new field to the Kernel tests.

Also, can you explore a non procedural alternative to check_plain?

The core issue is getting closer.

Should JSON API just focus on the data and rely on other web services to do data transformations: like converting markdown into HTML, applying text filters, …?

I'm not sure what you mean by "that".

If core exposes that as a data attribute, there is no reason not to expose it. However, I am not clear what is the point of this issue. I would assume that when core exposes it, it will be directly serialized in the JSON API payload.

If that is true, then we can close this issue.

I updated the patch for the current version of JSON API

Blocking this because of #2626924: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata.

In any case, we will need tests for this as well when the core issue is merged and we can just use that feature.

This is fixed. Thanks all!

Wait what, how did this go from being blocked to a commit (http://cgit.drupalcode.org/jsonapi/commit/?id=8dcb027), that doesn't even mention #2626924: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata as a @todo? Why did we commit code to the generic FieldItemNormalizer that is actually highly specific to a single field type?

Also, the code that was committed is severely broken, it's missing cacheability metadata for the processed text!

I think http://cgit.drupalcode.org/jsonapi/commit/?id=8dcb027 needs to be reverted.

I'm good reverting this, I also think that we may want to be proactive and try to pull thing forward instead of pushing from behind.

Reverting.

Marked #2919996: Process formatted text fields before output as a duplicate with the following comment:

This is a duplicate of #2775205: [PP-2] [FEATURE] Discus how to make JSON API use text input formats for long text fields.

#2626924: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata is A) making the processed property on text fields better/more complete, B) then marking it non-internal (which is a new concept since #2871591: Allow ComplexData in TypedData to specify computed properties that should be exposed in normalization and other contexts). Then the processed text (i.e. with filters applied) will show up automatically in REST responses.
#2921257: On Drupal 8.5, JSON API should respect Typed Data's new ::isInternal(), and JSON API Extras should use ::setInternal() is bringing this general concept (of exposing non-internal computed fields) to JSON API.

Note that since #2626924-166: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata (3 weeks ago), #2626924 has been moving forward again, because all blockers were fixed.

And since #2626924-204: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata (2 weeks ago) it has literally been blocked on reviews.

To the 8 followers of this issue: please help review that one! Once that's committed, this will automatically be fixed in JSON API too! And I solemnly pledge to backport it to JSON API sites running on Drupal 8.4, to ensure a smooth update path, and to ensure you can don't have to wait for Drupal 8.5 to be released in a few months!

#2626924: Include processed text in normalizations: "text" field type's "processed" computed property should be non-internal and carry cacheability metadata is in, which I think makes this no longer postponed?

That's great news! Thanks for the update @larowlan.

There's no longer anything to do here: once #2921257: On Drupal 8.5, JSON API should respect Typed Data's new ::isInternal(), and JSON API Extras should use ::setInternal() lands, this issue will be solved as well! Keeping it around for now though, to consider backporting this inside JSON API for Drupal 8.4 sites.

And since #2921257 is itself postponed on another issue, marking this PP-2.

#2921257: On Drupal 8.5, JSON API should respect Typed Data's new ::isInternal(), and JSON API Extras should use ::setInternal() was completed some time ago 🎉