Follow-up to #2859772: Update Symfony components to ~2.8.18
Follow-up to #2840596: Update Symfony components to ~2.8.16
While we now have Symfony updated to 2.8.18, other dependencies still need to be updated.
- Removing zendframework/zend-hydrator (1.0.0)
- Removing composer/installers (v1.0.21)
- Installing composer/installers (v1.2.0)
- Updating wikimedia/composer-merge-plugin (v1.3.1 => v1.4.0)
- Updating composer/semver (1.0.0 => 1.4.2)
- Updating doctrine/inflector (v1.0.1 => v1.1.0)
- Updating doctrine/cache (v1.4.2 => v1.6.1)
- Updating doctrine/common (v2.5.1 => v2.6.2)
- Updating egulias/email-validator (1.2.9 => 1.2.14)
- Updating guzzlehttp/promises (1.2.0 => v1.3.1)
- Updating psr/http-message (1.0 => 1.0.1)
- Updating guzzlehttp/psr7 (1.3.1 => 1.4.2)
- Updating masterminds/html5 (2.2.1 => 2.2.2)
- Updating paragonie/random_compat (v2.0.2 => v2.0.10)
- Updating psr/log (1.0.0 => 1.0.2)
- Updating symfony/psr-http-message-bridge (v0.2 => v1.0.0)
- Updating zendframework/zend-diactoros (1.1.3 => 1.3.10)
- Updating zendframework/zend-stdlib (2.7.3 => 3.0.1)
- Updating zendframework/zend-escaper (2.5.1 => 2.5.2)
- Updating zendframework/zend-feed (2.5.2 => 2.7.0)
- Updating guzzlehttp/guzzle (6.2.1 => 6.2.3)
- Updating fabpot/goutte (v3.1.2 => v3.2.1)
- Updating mikey179/vfsstream (v1.6.0 => v1.6.4)
- Updating sebastian/recursion-context (1.0.1 => 1.0.5)
- Updating sebastian/exporter (1.2.1 => 1.2.2)
- Updating sebastian/diff (1.3.0 => 1.4.1)
- Updating phpspec/prophecy (v1.5.0 => v1.7.0)
- Updating phpunit/php-file-iterator (1.4.1 => 1.4.2)
- Updating phpunit/php-timer (1.0.7 => 1.0.9)
- Updating phpunit/php-token-stream (1.4.8 => 1.4.11)
- Updating sebastian/environment (1.3.2 => 1.3.8)
- Updating sebastian/global-state (1.0.0 => 1.1.1)
- Removing behat/mink (dev-master 12e09bf)
- Installing behat/mink (dev-master 9ea1ceb)
Fix it.
None
Hopefuly none.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | update_non_symfony-2862254-23.patch | 56.89 KB | slasher13 |
| #18 | update_non_symfony-2862254-18.patch | 56.89 KB | slasher13 |
Comments
Comment #2
pwolanin commentedComment #3
pwolanin commentedRunning a full composer update brings in a lot of changes (see attached patch)
minor version updates:
no longer required: "zendframework/zend-hydrator"
new:
"phpdocumentor/reflection-common",
"webmozart/assert",
Comment #5
cilefen commentedComment #6
jibranI think we should identify the trivial updates here so that we can move them to 8.3.x and major updates should be moved to separate 8.4.x only issue.
Comment #7
slasher13patch releases only
Comment #8
slasher13missed jcalderonzumba/*
Comment #9
jibranPerfect. Fingers crossed for green.
Comment #10
jibranDo you think we should update all the packages listed by
composer outdated -m?Comment #12
slasher13Interdiff to #7
replace dev dependency of behat/mink
Hopefully it can be committed step by step and we can identify the problematic packages.
If we can't update the package, we should adapt version dependencies in composer.json.
Comment #14
jibranNope, we can't do that. We are actually blocked on https://github.com/minkphp/Mink/issues/725.
Comment #15
jibranLet's try to update all the outdated packages to minor versions.
Comment #17
jibranRevert the twig update as well. Now we need two follow-up issues one for
jcalderonzumba/*pacakges and one fortwig/twig.Other than that I think we should commit this ASAP and revert it if we find any BC break just like we did with symfony 3 update.
Comment #18
slasher13change versions
doctrine/annotations (v1.4.0 => v1.2.7)
doctrine/collections (v1.4.0 => v1.3.0)
doctrine/common (v2.7.2 => v2.6.2)
zendframework/zend-stdlib (3.1.0 => 3.0.1)
because they require php >= 5.6
and update symfony/psr-http-message-bridge
Comment #19
pwolanin commentedI noticed the same about php 5.6 from doctrine (forgot to submit the comment earlier). At what point do we stop supporting php 5.5?
Do we care that this is pushing the minimum PHP to 5.6?
Also going to PHP 5.6
Comment #20
cilefen commented#2842431: [policy] Remove PHP 5.5, 5.6 support in Drupal 8.7
Comment #21
jibranI have updated the issue summary. Let's see what maintainers feel about this.
There is no code change and tests are passing and minimum PHP version requirement is fulfilled so setting it to RTBC.
Should we create a meta issue from
composer outdatedoutput? Currently, there is no way to track the library upgrades.Comment #22
alexpottAgain I think we should try to be a bit more liberal here - maybe update it to
^2.5since there is obviously nothing in the code base that demands 2.6 so maybe you have a project that demands 2.5 and needs more time to upgrade to 2.6.How come where not use something more liberal like
^1.0. There is a general move away from the~because it is hard to understand.Comment #23
slasher13#22.1 done
#22.2 done
Comment #24
jibranBack to RTBC as #22 is addressed.
Comment #25
alexpottCommitted e83f9f6 and pushed to 8.4.x. Thanks!
Committed 7007e7b and pushed to 8.3.x. Thanks!
Here's the log of running composer install
All looks good. The only non minor version updates are things that Drupal does not depend on directly. There are
symfony/psr-http-message-bridgeandzend-stdlibComment #28
jibranThank you, @alexpott. Follow-ups as per #17.
#2832672: [PP-1] Upgrade jcalderonzumba/* for better test performance is for updating
jcalderonzumba/*packages.#2864031: Update twig/twig from v1.25.0 to v1.32.0 is for updating twig to 1.33.0
Comment #29
jibranCreated #2864037: [META] Update core PHP dependencies for #21.
Comment #30
alexpottI really think we should consider #2843328: Enforce minimum PHP version in composer dependencies given the issues here.
Comment #31
eric_a commentedComment #32
eric_a commentedNow that composer/installers went above 1.0.24 I believe now is also the time to more or less complete extension installer functionality by also facilitating proper paths for custom modules and themes in 8.3.0 next to contrib paths which we've already added, and quickly up the requirement from
^1.0.21to^1.0.24in #2866109: Composer/installers update to 1.2.0 adding support for installing custom modules and themes to directories other than /vendor.Comment #33
xjm