Feels like a bug to ship 8.3.0 with explicit installer configuration for contrib but not for private repo custom modules and themes, now that we recently have locked composer/installers on 1.2.0 instead of 1.0.21. (Custom modules and themes paths requires composer/installers package v1.0.24 and up.)
I think we'd best change the config and version requirement before 8.3.0, because upping the version requirement in a patch release could change install location from vendor dir to custom dir, even if I find it rather hard to believe that drupal/drupal users would actually have installed their custom Drupal modules and themes in the vendor dir.
We'll also be able to clean-up the installer paths config (comparison) docs in https://www.drupal.org/docs/develop/using-composer/using-composer-to-man....
Comment | File | Size | Author |
---|---|---|---|
#7 | 2866109-7.patch | 1.32 KB | Eric_A |
#3 | 2866109-3.patch | 1.32 KB | Eric_A |
Comments
Comment #2
Eric_A CreditAttribution: Eric_A commentedComment #3
Eric_A CreditAttribution: Eric_A commentedComment #4
Eric_A CreditAttribution: Eric_A commentedComment #6
alexpottThis will need a different patch for 8.4.x
The change makes sense to me.
Comment #7
Eric_A CreditAttribution: Eric_A commentedAh, thanks. Here's the patch for 8.4.x
Comment #8
Eric_A CreditAttribution: Eric_A commentedComment #9
DrIPA CreditAttribution: DrIPA commentedWorks for me
Comment #10
alexpottCommitted 13360cf and pushed to 8.4.x. Thanks!
I'm not sure the release managers will want to make this change to 8.3.x. This file is really just an example and for projects using composer they are supposed to edit it. That said it is truly helpful to know how to configured this. Personally I'm +1 but not my call.
Setting to patch to be ported and 8.3.x for a choice. @Eric_A if you want to re-upload the 8.3.x patch that'd be great - it is alway helpful when the last patch on the rtbc issue is the correct patch to commit next.
Comment #12
alexpottDiscussed with @catch and @cilefen. @catch was ambivalent and @cilefen was +1. Let's put this in to 8.3.x - I think this only helps people.
Committed 1a349c1 and pushed to 8.3.x. Thanks!
Comment #14
Eric_A CreditAttribution: Eric_A commentedHa, I just did a failed attempt to re-upload and change status. Thanks a bunch everyone!
I do believe there's real value in having the requirement at ^1.0.24, which is the one that added support for drupal-custom-module and drupal-custom-theme, and in hinting people at the possiblity of turning custom modules into private packages.
I'll see if I can update the docs later today.
Comment #15
Eric_A CreditAttribution: Eric_A commentedShoot, didn't mean to still upload it.
Comment #16
Eric_A CreditAttribution: Eric_A commentedUpdated docs regarding repository config and installer paths config text and comparison table.
https://www.drupal.org/node/2718229/revisions/view/10401772/10423097
https://www.drupal.org/docs/develop/using-composer/using-composer-to-man...
Comment #17
alexpottWe should add something about this to the release notes because people can update there root composer.json to benefit from this.
Perhaps something like this:
Comment #18
alexpottComment #19
Eric_A CreditAttribution: Eric_A commentedYou beat me to it. Thanks, @alexpott!
Comment #21
xjm