Problem/Motivation

composer/installers installs packages to the correct location based on the specified package type. Drupal core composer/installers since forever (#2373197: Reference Composer Installers as a dependency of a Drupal project) but it is not configured properly so far. Contrib modules should go to modules/contrib. Contrib themes should go to themes/contrib etc.

Proposed resolution

Add a good default configuration for installer-paths. This will improve the ootb experience for composer based workflows.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 2813897-11.patch1.15 KBwebflo
#7 2813897-7.patch1.21 KBwebflo
#2 2813897-2.patch662 byteswebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2813897-2.patch662 bytes

Copy from https://github.com/drupal-composer/drupal-project/blob/8.x/composer.json without the web prefix.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

+1 for RTBC from me.

I've seen support requests about this in the Commerce, Address, Search API Solr issue queues. People expect modules/contrib to be used, but it isn't. For 8.2.x we'll want to have a documentation page, but for 8.3.x we can give people one less thing to configure.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Works for me!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2813897-2.patch, failed testing.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2813897-7.patch1.21 KB

With updated composer hash.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs work » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

+1 This is going to simplify the lives of contributed project developers and writing documentation. If we say something is a best practice, core should reflect that :)

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

Can we leave libraries out, for now a least? That is somewhat contentious, see #667058: Add a libraries folder with a README.txt in it to DRUPAL_ROOT.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2813897-11.patch1.15 KB

Alright, this time without libraries.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 2098296 and pushed to 8.3.x. Thanks!

  • alexpott committed 2098296 on 8.3.x 
    Issue #2813897 by webflo, tstoeckler: Add composer installer-paths by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.