Follow-up to #2840596: Update Symfony components to ~2.8.16

Problem/Motivation

See https://github.com/symfony/symfony/releases/tag/v2.8.18.

Proposed resolution

Update Symfony components

Remaining tasks

Agree on moving it to 8.3.x

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#7 update_symfony-2859772-7.patch27.76 KBslasher13
#4 update_symfony-2859772-4.patch28.46 KBslasher13
#4 interdiff.txt3.23 KBslasher13
#2 update_symfony-2859772-2.patch25.33 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new update_symfony-2859772-2.patch25.33 KB

I pinned down the symfony/browser-kit version to avoid major version jump.

diff --git a/core/composer.json b/core/composer.json
index 503704c..b951c46 100644
--- a/core/composer.json
+++ b/core/composer.json
@@ -43,6 +43,7 @@
         "jcalderonzumba/mink-phantomjs-driver": "~0.3.1",
         "mikey179/vfsStream": "~1.2",
         "phpunit/phpunit": "~4.8",
+        "symfony/browser-kit": ">=2.8.13 <3.0",
         "symfony/css-selector": "~2.8"
     },
     "replace": {

Ran composer -vvv update symfony/* --with-dependencies
Result.

composer show symfony/*
symfony/browser-kit             v2.8.18 Symfony BrowserKit Component
symfony/class-loader            v2.8.18 Symfony ClassLoader Component
symfony/console                 v2.8.18 Symfony Console Component
symfony/css-selector            v2.8.18 Symfony CssSelector Component
symfony/debug                   v2.8.18 Symfony Debug Component
symfony/dependency-injection    v2.8.18 Symfony DependencyInjection Component
symfony/dom-crawler             v2.8.18 Symfony DomCrawler Component
symfony/event-dispatcher        v2.8.18 Symfony EventDispatcher Component
symfony/http-foundation         v2.8.18 Symfony HttpFoundation Component
symfony/http-kernel             v2.8.18 Symfony HttpKernel Component
symfony/polyfill-apcu           v1.3.0  Symfony polyfill backporting apcu_* functions to lower PHP versions
symfony/polyfill-iconv          v1.3.0  Symfony polyfill for the Iconv extension
symfony/polyfill-mbstring       v1.3.0  Symfony polyfill for the Mbstring extension
symfony/polyfill-php54          v1.3.0  Symfony polyfill backporting some PHP 5.4+ features to lower PHP versions
symfony/polyfill-php55          v1.3.0  Symfony polyfill backporting some PHP 5.5+ features to lower PHP versions
symfony/process                 v2.8.18 Symfony Process Component
symfony/psr-http-message-bridge v0.2    PSR HTTP message bridge
symfony/routing                 v2.8.18 Symfony Routing Component
symfony/serializer              v2.8.18 Symfony Serializer Component
symfony/translation             v2.8.18 Symfony Translation Component
symfony/validator               v2.8.18 Symfony Validator Component
symfony/yaml                    v2.8.18 Symfony Yaml Component

Status: Needs review » Needs work

The last submitted patch, 2: update_symfony-2859772-2.patch, failed testing.

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.23 KB
new update_symfony-2859772-4.patch28.46 KB

https://www.drupal.org/node/2712647#comment-11978117

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

There is no api break so I think it is good to go in 8.3.x.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: update_symfony-2859772-4.patch, failed testing.

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new update_symfony-2859772-7.patch27.76 KB

re-roll and back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Discussed with @catch we agreed that this should get into 8.3.x asap since it is a patch update. Can someone check if any of the other dependencies need updating?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Committed and pushed b409552 to 8.4.x and 15ebfad to 8.3.x. Thanks!

  • alexpott committed b409552 on 8.4.x 
    Issue #2859772 by slasher13, jibran: Update Symfony components to ~2.8....

  • alexpott committed 15ebfad on 8.3.x 
    Issue #2859772 by slasher13, jibran: Update Symfony components to ~2.8....
pwolanin’s picture

pwolanin commented

It looks like paragonie/random_compat does.

Maybe others

pwolanin’s picture

pwolanin commented

follow-up issue: #2862254: Update non-Symfony dependencies before 8.3.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +8.3.0 release notes
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev