CommentFileSizeAuthor
#20 interdiff.txt850 byteswim leers
#20 smartcache-2560959-20.patch74.95 KBwim leers
#19 interdiff.txt1004 byteswim leers
#19 smartcache-2560959-19.patch74.15 KBwim leers
#17 interdiff.txt681 byteswim leers
#17 smartcache-2560959-17.patch73.22 KBwim leers
#14 interdiff.txt999 byteswim leers
#14 smartcache-22560959-14.patch72.59 KBwim leers
#13 smartcache-347-plus-2504139-99.patch71.65 KBwim leers
#10 interdiff.txt15.68 KBwim leers
#10 smartcache-2560959-10.patch68.98 KBwim leers
#8 interdiff.txt835 byteseffulgentsia
#8 smartcache-2560959-8.patch55.54 KBeffulgentsia
#6 interdiff.txt750 byteswim leers
#6 smartcache-339-plus-2559011-13--1.patch55.61 KBwim leers
#4 smartcache-339-plus-2559011-13.patch55.17 KBwim leers
#2 smartcache-339-plus-2559011-13.patch58.11 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new smartcache-339-plus-2559011-13.patch58.11 KB

Status: Needs review » Needs work

The last submitted patch, 2: smartcache-339-plus-2559011-13.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-339-plus-2559011-13.patch55.17 KB

The first hunk in FormBuilder shouldn't have been included; I badly merged the two patches.

Status: Needs review » Needs work

The last submitted patch, 4: smartcache-339-plus-2559011-13.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-339-plus-2559011-13--1.patch55.61 KB
new interdiff.txt750 bytes

Status: Needs review » Needs work

The last submitted patch, 6: smartcache-339-plus-2559011-13--1.patch, failed testing.

effulgentsia’s picture

effulgentsia commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-2560959-8.patch55.54 KB
new interdiff.txt835 bytes

This fixes RedirectTest.

Status: Needs review » Needs work

The last submitted patch, 8: smartcache-2560959-8.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-2560959-10.patch68.98 KB
new interdiff.txt15.68 KB

This fixes the rest, and improves #8.

Status: Needs review » Needs work

The last submitted patch, 10: smartcache-2560959-10.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (duplicate)

Hurray! Green!

Opened #2561775: Forms without $form['#action'] set get their action automatically generated based on current path + query args: cacheability metadata is missing to commit the fix developed in this issue. And #2559011: Ensure form tokens are marked max-age=0 was committed in the mean time.

This testing issue has served its purpose.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new smartcache-347-plus-2504139-99.patch71.65 KB

Now checking if #2429617-347: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) + #2504139-99: Blocks containing a form include the form action in the cache, so they always submit to the first URL the form was viewed at are green.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new smartcache-22560959-14.patch72.59 KB
new interdiff.txt999 bytes

Forgot one hunk. That fixes one fail. But the remaining 4 fails in SearchCommentTest are because we went with a different solution than in #1–#12. Will debug those tomorrow unless someone beats me to it.

The last submitted patch, 13: smartcache-347-plus-2504139-99.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 14: smartcache-22560959-14.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-2560959-17.patch73.22 KB
new interdiff.txt681 bytes

Status: Needs review » Needs work

The last submitted patch, 17: smartcache-2560959-17.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smartcache-2560959-19.patch74.15 KB
new interdiff.txt1004 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new smartcache-2560959-20.patch74.95 KB
new interdiff.txt850 bytes

The last submitted patch, 19: smartcache-2560959-19.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 20: smartcache-2560959-20.patch, failed testing.

Wim Leers queued 20: smartcache-2560959-20.patch for re-testing.

The last submitted patch, 20: smartcache-2560959-20.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Postponed

This issue has again served its purpose: #2429617-348: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!).

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Closed (works as designed)

This was opened to help test and issue that is now closed. Time to close this one.