Module development and code questions

Copy of this issue for quick feedback.
--
I am having a trouble developing a module. In my hook_init() function, I call both the function drupal_get_path, and theme_add_style. Whenever I am logged into the admin user account, everything works fine, but when I am anonymous, it comes up with a fatal error because it can't find either function. In drupal 4.6, I can call require_once("includes/common.inc"), but in 4.7, theme_add_style is not found still.

Hello,

Well, this has been brought up a few times before, but I think my case is a little different.
I developed node_article.module. Now, I need to make it work with our own magazine!

At Free Software Magazine, we use our own article format for a number of reasons (the main one being automatic composition). An example of an article is at the bottom of this message.

Now, here is what I need to do:

1) Create a new filter which transforms the XML below into HTML

2) Create a new input format which uses the above filter

3) Make this filter available ONLY for node_article nodes

4) Make this filter the ONLY option for node_article nodes

Why 3)? Well, because in the site I will also have blogs, and probably won't want people to input their blogs using the article format.
Why 4)? Because I definitely won't want authors to hand in articles in any other format

For what I see, the input format is set by role, rather than node type. Is this _always_ the case? If the answer is "yes", then I'll need to hack node_article so that it only accepts a specific input type. But this won't solve 3) (that is, a person who is a blogger AND an author will be able to hand in blogs using the article format).

Any ideas about this one?

Thanks a million!

-------
Example of an article:

<article>

<contents>

<p>This is the article's introduction. This paragraph will display as a blurb on the home page or wherever else the article will display. It's crucial to make this section interesting, so that your readers won't stop reading the article.</p>

Hello,

I wrote node_article.module, a complete module that manages an article's workflow with author, editor, editor in chief and copyeditor. Everybody a part from chief and author are optional.

It's been created to work well while creating Free Software Magazine.

Hello,

As most of you know, I've written node_article.
My question now is about themes.

I wrote a function called:

theme_node_article_editing_info($node)

I followed the node_sample template to start with.
Then, a function calls:

Hello,

I have just finished developing node_article.
Now: in the node, I store the editor's uid. However, when I deal with the node I want to deal with the editor's login name.
So, in node_article_load I put:

 // Work out the node_id for the chosen editor
  if($additions->editor_uid == 0){
    $additions->editor_uid_name='';
  } else {
    $tmp=user_load( array('uid' => $additions->editor_uid));
    if(!$tmp){
      $additions->editor_uid_name="ERROR LOADING USER '".$additions->editor_uid."'!";
    } else {
      $additions->editor_uid_name = $tmp->name;
    }
  }

then, in node_article_update I have:

  // Work out the node_id for the chosen editor
  if($node->editor_uid_name == ''){
    $node->editor_uid=0;
  } else {
    $tmp=user_load(array('name' => $node->editor_uid_name));
    $node->editor_uid=$tmp->uid;
  }

Is this structurally OK?

In this function, I also create:

$additions->editing_finished

This variable will check if the author and the editor are assigned AND they is OK with the current version of the article - if that's the case, $additions->editing_finished is set to one. This way, people loading the node know that the editing is finished.
Again: is this structurally OK?

Finally, I need an HTML "editing string", which give a LOT of editing information in a very tiny string (using colour codes and font sizes, it tells you if the author, the editor and the editor in chief are OK, who is currently in control, and so on).

Hi,

I've finally finished developing my article_node module.
However, I feel a little bit uneasy about it. Rhe main reason is that I am not 100% sure that I did things "right".

My main question is: how much logic should go into node_article_insert and node_article_update?

At the moment, I allow people to specify an editor for the article. Obviously, in the form the editor is specified by account name rather than UID.
So, in node_article_update I have something like:

  // Work out the node_id for the chosen editor
  if($node->editor_uid_name == ''){
    $node->editor_uid=0;
  } else {
    $tmp=user_load(array('name' => $node->editor_uid_name));
    $node->editor_uid=$tmp->uid;
  }

Then, I decided that if the editor is not sent then the editor CANNOT be "ok" with the article. So, later on in node_article_update, I have:

  if($node->editor_uid == 0){ $node->editor_ok = 0; }

And then things get worse...
In the form, I have an hidden field:

  $form['workout_oks'] = array('#type' => 'hidden', '#default_value' => '1', '');

This field will tell my module that I want to work out who's OK with what (if a new version of the node is saved, then the author's OK is automatically set to 0).
In node_article_update, I then have:


if($node->workout_oks == 1 && $op == 'update'){
_node_module_reset_other_peoples_oks($node);