The D6 menu system has built-in support for keeping the code base smaller by only including the code needed for a particular path.

We can do a similar thing for the Zen theme. Only include the code needed for a particular feature if we're actively using that feature.

For example, block editing links are only needed for users with the proper permissions. And the zen_theme() function is only needed when the theme registry is being rebuilt.

I'm taking http://raincitystudios.com/blogs-and-pods/steve-krueger/raincity-studios... seriously. :-)

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Just removed 80 lines from the end of template.php by conditionally including the code that is only needed while rebuilding the theme registry or while displaying the theme settings forms.

http://drupal.org/cvs?commit=139333 Moved zen_theme() to template.theme-registry.inc.

http://drupal.org/cvs?commit=139335 Refactored zen_settings_init as zen_theme_get_default_settings and moved to template.theme-registry.inc.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

Removed 75 more lines.

http://drupal.org/cvs?commit=139344 Moved some comments from zen to STARTERKIT where they belong.

http://drupal.org/cvs?commit=139347 Moved block editing code to template.block-editing.inc.

http://drupal.org/cvs?commit=139349 Moved zen_preprocess_comment() to template.comment.inc.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

I also did:

* Optimized zen_breadcrumb()
* Moved some comments from zen to STARTERKIT where they belong
* Folded template-menus.php back into template.php since its not conditionally included
* Removed theme_username from STARTERKIT and zen_classic since it was fixed in Drupal 6.3
* Optimized zen_menu_item_link()
* Optimized path_to_zentheme()

More optimization ahead…

Down to 275 lines in template.php from previous 500 lines in 6.x-1.0-beta2.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Fixed

Down to 251 lines. :-)

Which, I just noticed is 2 lines shorter than the template.php in the Basic theme. ;-)
http://cvs.drupal.org/viewvc.py/drupal/contributions/themes/basic/templa...

Done (for now).

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Renzy’s picture

Renzy commented

deleted - apologies