Javascript (yoast_seo.js) code has a typo:

row 87:
if (typeof CKEDITOR !== "undefined") {

should be:
if (typeof CKEDITOR != "undefined") {

it's an small typo but could have performance issues in some computers.

CommentFileSizeAuthor
#3 error_typo-2874004-3.patch457 bytesharshita29

Comments

foreveryo created an issue. See original summary.

foreveryo’s picture

foreveryo commented
Issue summary: View changes
harshita29’s picture

harshita29 commented
StatusFileSize
new error_typo-2874004-3.patch457 bytes

Hi,
Here is the simple patch for the same

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Closed (won't fix)

Hi harshita29 and foreveryo,

I've not been able to find any references to the mentioned "performance issues". This stackoverflow answer suggests the difference doesn't really matter. Furthermore it's preferred to do strict type checking whenever conversion of types is not needed (which is the case here).

Therefor I'm closing this as won't fix.

Kind Regards,

Alexander
GoalGorilla