Problem/Motivation

XrayAuditBatchHelper::downloadAllCsvFinished() uses the plugin.manager.archiver service, deprecated in drupal:11.3.0 and removed from drupal:12.0.0 without replacement. See https://www.drupal.org/node/3556927.

Steps to reproduce

Run phpstan.

Proposed resolution

Create the ZIP file with \ZipArchive directly.

Issue fork xray_audit-3628811

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

juanjol created an issue. See original summary.

juanjol opened merge request !93

juanjol’s picture

juanjol
Primary language Spanish
commented
Status: Active » Needs review

Ready for review. The ZIP file is now created with ZipArchive directly.

This also fixes the CSV files being stored in the ZIP with their full server path. Now they are stored with just their file name.

The phpstan error left was already on 3.x and is fixed in #3628810.

lpeidro made their first commit to this issue’s fork.

lpeidro’s picture

lpeidro commented
Status: Needs review » Fixed

It works as expected. I merge the MR.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • lpeidro committed b1432134 on 3.x authored by juanjol 
    Issue #3628811: Create the ZIP file with ZipArchive instead of the...