We have tens of thousands of nodes to include in the sitemap - so running 400 on every cron-run will never get the sitemap completed. Could you add 1000 and 5000 as well? You should probably add a comment, so people don't set this to high and run into php timeouts, memory limits etc.

CommentFileSizeAuthor
#10 xmlsitemap-465658.patch1.18 KBAnonymous (not verified)
#7 xmlsitemap-465658.patch1.17 KBAnonymous (not verified)

Comments

avpaderno’s picture

It seems quietly reasonable. After all, if the cron tasks go in timeout, the saved database rows not are destroyed; therefore, there is no risk on allowing that.

The only problem for the user could be to not have the other cron tasks completed, but at the point it's up to the user to select the correct value for his configuration.

I give my +4 points for the feature.

avpaderno’s picture

This has been implemented.

Thanks for your report.

avpaderno’s picture

Status: Active » Fixed

Sigh!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Status: Closed (fixed) » Active

I am reopening this report that is a feature request made from a user, now that the requested feature does not appear anymore in the code because of the code roll-back.

Anonymous’s picture

Issue tags: +reimplement
Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new1.17 KB

Please review ASAP.

gbrussel’s picture

Looks like the indentation is a bit off.

avpaderno’s picture

It seems the patch uses tab characters where it should not. Coding standards suggest to use a two spaces indentation, rather than tab characters.

Anonymous’s picture

StatusFileSize
new1.18 KB

Thanks Kiam.

Anonymous’s picture

Status: Needs review » Fixed

Committed to CVS.

Status: Fixed » Closed (fixed)
Issue tags: -reimplement

Automatically closed -- issue fixed for 2 weeks with no activity.