See line in user.module function user_view_access

($account->access && $account->status && user_access('access user profiles'))

I saw recent patches for status but not for access. If a user has never logged in they should not be added to the site map as the page will return 403 anyway. We are getting hundreds of errors from Google about this.

An upgrade task to automatically remove such users from the existing sitemap would be welcome when this is fixed.

David

CommentFileSizeAuthor
#6 xmlsitemap-458398.patch1.2 KBAnonymous (not verified)
#1 xmlsitemap_user_094590.patch1.04 KBavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new xmlsitemap_user_094590.patch1.04 KB

This should be fixed in the latest commit I did. The attachment is the patch to use to apply the changes.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Fixed

I forgot to change the status.
Feel free to re-open it, if you still have the problem. Take in mind that the sitemap doesn't automatically update itself.

davidc’s picture

davidc commented

Works fine, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Closed (fixed) » Active

The issue report needs to be re-opened, after the code has been rolled back.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed
StatusFileSize
new xmlsitemap-458398.patch1.2 KB

The attached patch has been committed to CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.