The main table used by the project is emptied all times some settings are changed. This is not the correct thing to do, especially when the settings being changed would change the content of the site map, but not the content of the database table; in this cases, the correct way to proceed would be to flag the content of the cache file as obsolete.

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

The code has been changed in CVS.

There is surely something that can still be changed. Any feedback is welcome.

Anonymous’s picture

Anonymous (not verified) commented

It would be easier to review if you put up a patch file. Or a link to the CVS diff for the small changes.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Here the links for the differences between the commit I was talking of, and the previously committed code. The change d code includes also the code that has been moved to the correct module.

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...

I know the code must be changed, and I have already noticed some of the code that needs to be rewritten.
A review from somebody else would still help me in avoiding not necessary changes I could do because in the case I don't value correctly the situation.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

I am setting this report as fixed. The next step is to find a way for the modules to verify if they need to update the links they added to the site map. Just to make an example, if none of the nodes have been edited, and the priority of the content type has not been changed, then xmlsitemap_node.module doesn't need to change the links it added into the table used for the site map content.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.