This is a minor thing, perfectly able to wait until a 2.x release (if ever), but we could reduce the memory footprint of this module a tiny bit by moving the UI bits of the code to *.admin.inc files like most of core does.

CommentFileSizeAuthor
#7 xmlsitemap-fix-wsod-441732-7.patch1.94 KBwebchick

Comments

avpaderno’s picture

It can be done right after the code for populating the module database tables is implemented as cron task.

avpaderno’s picture

Assigned: Unassigned » avpaderno
avpaderno’s picture

The menu callbacks have been moved into separated .inc files.

avpaderno’s picture

Status: Postponed » Fixed

I should have changed the status as well.

Anonymous’s picture

Priority: Minor » Critical
Status: Fixed » Active

Well you forgot

Index: xmlsitemap/xmlsitemap.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/xmlsitemap/xmlsitemap/Attic/xmlsitemap.module,v
retrieving revision 1.1.2.94
diff -u -p -r1.1.2.94 xmlsitemap.module
--- xmlsitemap/xmlsitemap.module	28 Apr 2009 14:54:54 -0000	1.1.2.94
+++ xmlsitemap/xmlsitemap.module	28 Apr 2009 21:57:07 -0000
@@ -118,6 +118,7 @@ function xmlsitemap_menu() {
     'page callback' => 'xmlsitemap_output',
     'access callback' => '_xmlsitemap_anonymous_access',
     'type' => MENU_CALLBACK,
+    'file' => 'xmlsitemap.pages.inc',
   );
   $chunk_size = variable_get('xmlsitemap_chunk_size', 1000);
   $link_count = xmlsitemap_link_count();
@@ -130,6 +131,7 @@ function xmlsitemap_menu() {
         'page arguments' => array((string) $chunk),
         'access callback' => '_xmlsitemap_anonymous_access',
         'type' => MENU_CALLBACK,
+        'file' => 'xmlsitemap.pages.inc',
       );
     }
   }
webchick’s picture

Status: Active » Fixed

Looks like this was fixed. With latest cvs up, I don't see this anymore.

webchick’s picture

Title: Use page splitting to move UI code to .inc files » WSOD on sitemap.xml (was: Use page splitting to move UI code to .inc files)
Category: task » bug
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new1.94 KB

Oh nevermind. I get it. Marked #447860: sitemap.xml is a WSOD a duplicate of this.

I confirmed that earnie's fix solves the problem, so marking RTBC. Here's a patch.

avpaderno’s picture

Title: WSOD on sitemap.xml (was: Use page splitting to move UI code to .inc files) » WSOD on sitemap.xml
Status: Reviewed & tested by the community » Fixed

This has been fixed in CVS.

Thanks for the report, and with the help in reviewing the code of the project.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.