When viewing the list of custom links by clicking on the custom links tab the xmlsitemap_custom module tries to show all the custom links. This can be an issue if you have a large number of custom links as it may timeout.

CommentFileSizeAuthor
#10 Selection_215.png43.47 KBpifagor
#5 custom_pager_broken-2130189.patch1.55 KBwojtha
#1 custom_pager_broken-2130189.patch955 bytesppound

Comments

ppound’s picture

ppound commented
StatusFileSize
new custom_pager_broken-2130189.patch955 bytes
NetOctet’s picture

NetOctet commented

Hi all.
This bug is not yet corrected.

Patch #1 working.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: custom_pager_broken-2130189.patch, failed testing.

wojtha’s picture

wojtha commented
StatusFileSize
new custom_pager_broken-2130189.patch1.55 KB

I've reapplied the patch from @ppound and I can confirm that it works

wojtha’s picture

wojtha commented
Title: pager broken when listing custom links » Pager broken when listing custom links
Status: Needs work » Needs review
wojtha’s picture

wojtha commented
Status: Needs review » Reviewed & tested by the community

Since my patch was only formal reapply of the @ppound original solution I'm giving RTBC to this.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed #5 to 7.x-2.x and also bumped the per-page limit to 25. Marking as to be ported to 8.x-1.x since I'm not sure if this also needs to be fixed there.

  • Dave Reid committed abb7002 on 7.x-2.x 
    Issue #2130189 by wojtha, ppound: Fixed broken pager on custom links...
pifagor’s picture

pifagor commented
Status: Patch (to be ported) » Fixed
StatusFileSize
new Selection_215.png43.47 KB

As far as I understand, all is well, so I close these issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.