In xmlsitemap_link_delete_multiple() we have a @todo for invoking a hook when XML Sitemap links are deleted. Let's do it :)

CommentFileSizeAuthor
#6 xmlsitemap-xmlsiteap_link_actions-1410600-6.patch4.8 KBnikolabintev
#5 1410600-5.patch4.63 KBamateescu
#4 1410600-4.patch4.42 KBamateescu
#1 1410600-hook_xmlsitemap_link_delete.patch1.68 KBamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 1410600-hook_xmlsitemap_link_delete.patch1.68 KB

Another @todo was fixed in this patch as well, because #151452: Uninstalling modules does not follow dependencies and can lead to WSOD has been fixed for a long time :)

Status: Needs review » Needs work

The last submitted patch, 1410600-hook_xmlsitemap_link_delete.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review

Bot hickup. I did a manual retest and it looks good now.

amateescu’s picture

amateescu commented
Title: Add hook for link deletion » Add hooks for all xmlsitemap_link_* functions
StatusFileSize
new 1410600-4.patch4.42 KB

This one takes care of xmlsitemap_link_update_multiple() and xmlsitemap_link_delete_multiple() as well.

amateescu’s picture

amateescu commented
StatusFileSize
new 1410600-5.patch4.63 KB

Ha, good luck getting link ids and types with the hook invocation order from #4 :) This one should be better.

nikolabintev’s picture

nikolabintev commented
Issue summary: View changes
StatusFileSize
new xmlsitemap-xmlsiteap_link_actions-1410600-6.patch4.8 KB

I also need these functionalities, but the patches created 7 years ago cannot be applied now. I'm applying a patch compatible with the latest dev version of the module.