As per #1774618: Charset definition missing in XML-RPC invalid !link placeholders are used.

CommentFileSizeAuthor
#7 interdiff-2628800-2-7.txt8.29 KBfgm
#7 2628800-test_placeholders-7.patch9.04 KBfgm
#2 2628800.patch3.28 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 2628800.patch3.28 KB

Starting with the placeholders.

Status: Needs review » Needs work

The last submitted patch, 2: 2628800.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Reviewed & tested by the community

Lol, the guzzle problems are with the patch in #1774618: Charset definition missing in XML-RPC. So only the placeholders are a problem. This passes well except on postgres where there is a branch fail.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Tests fail on xmlrpc head » Tests fail on xmlrpc head with invalid !link placeholders.
Issue summary: View changes
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Needs work

Looks like we have three more of these, in xmlrpc_help() and XmlRpcExampleController::info().

      $output .= '<p>' . t('The XML-RPC module gives external systems the opportunity to communicate with the site through the <a href="http://en.wikipedia.org/wiki/XML-RPC">XML-RPC protocol</a>. An XML-RPC client can communicate with the site by making a request to <a href="!xrphp">xmlrpc.php</a>. For more information, see <a href="!xrdocs">the online documentation for the XML-RPC module</a>.', array(
          '!xrphp' => \Drupal::url('xmlrpc.php'),
          '!xrdocs' => 'https://drupal.org/documentation/modules/xmlrpc',
        )) . '</p>';

      '#title' => $this->t('These methods are supported by !server', array('!server' => check_url($server))),
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review
StatusFileSize
new 2628800-test_placeholders-7.patch9.04 KB
new interdiff-2628800-2-7.txt8.29 KB

How about this ? Tests pass locally.

Status: Needs review » Needs work

The last submitted patch, 7: 2628800-test_placeholders-7.patch, failed testing.

  • fgm committed 773cc95 on 8.x-1.x 
    Issue #2628800 by fgm, Gábor Hojtsy: Fixed invalid !link placeholders...
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Fixed

The CI fails are unrelated, so committed to HEAD. Thanks.

The last submitted patch, 2: 2628800.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 7: 2628800-test_placeholders-7.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Fixed

This is actually fixed : errors come from the bot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.