Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Now that issue 3082394 has been accepted, I'd like to fix the CDN footer for the GCWeb theme.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | fix-cdn-footer-gcweb-theme-3104664-8.patch | 683 bytes | smulvih2 |
| #3 | fix-cdn-footer-gcweb-theme-3104664-3.patch | 1.34 KB | smulvih2 |
| #2 | fix-cdn-footer-gcweb-theme-3104664-2.patch | 2.47 KB | smulvih2 |
Comments
Comment #2
smulvih2This patch fixes the template file
page--gcweb.html.twigto allow for language negotiation. I'm usinghttps://www150.statcan.gc.ca/n1/wet-boew4b/ajax/sitefooter-as the CDN URL in the WxT Bootstrap settings. Some CSS changes were needed as the DOM structure from CDN doesn't match the expected output; .wb-navcurr is not wrapped in div.landscape as on Canada.caComment #3
smulvih2Here's a new patch that wraps the footer top section in
div.landscape. I think this is a better approach then #2 above as it doesn't require any changes to styles.Comment #4
joseph.olstadPatch applies cleanly, seems to work as advertised.
Comment #5
joseph.olstadMoving to the wxt project, while it is a wxt_bootstrap issue and this theme CAN be used by it'self without wxt but for issue maintenance, the way we've been dealing with component issues is to keep them in the wxt project
RTBC
Comment #6
sylus commentedHi there ^_^
Super sorry haven't had a chance to look at this, I asked someone from the team to take a look.
I think my only concern was that it uses javasript to replace the markup can't we just adjust the template directly?
I also don't think we want this to replace other theme markups and only a certain one?
Definitely happy to work with you on this, and appreciate joseph.olstad take a first look.
You both are awesome :D
Comment #7
sylus commentedComment #8
smulvih2@sylus I agree, the javascript approach is a bit hacky. I had some time to revisit this and I think the new approach, which only requires changes to the template file, is much better.
The issue with the returned CDN data is the top menu is not wrapped in a
.landscapediv. Using a technique here (https://wet-boew.github.io/v4.0-ci/demos/data-ajax/data-ajax-en.html) I was able to target CDN content using a CSS class selector and put the nav inside a.landscapediv.Comment #9
smulvih2Comment #10
sylus commentedThis looks good really appreciate it :D
Committed and attributed! Thanks again!
Comment #12
smulvih2