Hi,

Please find the list of Drupal coding standard issue


FILE: /root/repos/pareviewsh/pareview_temp/migrate_wordpress.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
--------------------------------------------------------------------------

Time: 66ms; Memory: 4Mb

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: ...t/repos/pareviewsh/pareview_temp/src/Plugin/migrate/source/Terms.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
32 | ERROR | [x] Short array syntax must be used to define arrays
53 | ERROR | [x] Short array syntax must be used to define arrays
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
78 | ERROR | [x] Short array syntax must be used to define arrays
79 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...t/repos/pareviewsh/pareview_temp/src/Plugin/migrate/source/Users.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
32 | ERROR | [x] Short array syntax must be used to define arrays
54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
68 | ERROR | [x] Short array syntax must be used to define arrays
69 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...epos/pareviewsh/pareview_temp/src/Plugin/migrate/source/Comments.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
36 | ERROR | [x] Short array syntax must be used to define arrays
78 | ERROR | [x] Short array syntax must be used to define arrays
79 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...t/repos/pareviewsh/pareview_temp/src/Plugin/migrate/source/Posts.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
36 | ERROR | [x] Short array syntax must be used to define arrays
83 | ERROR | [x] Short array syntax must be used to define arrays
84 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...os/pareviewsh/pareview_temp/src/Plugin/migrate/source/Vocabulary.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
33 | ERROR | [x] Short array syntax must be used to define arrays
62 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
76 | ERROR | [x] Short array syntax must be used to define arrays
77 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Comments

pvsureshmca created an issue. See original summary.

pvsureshmca’s picture

Assigned: pvsureshmca » Unassigned
Status: Needs work » Needs review
StatusFileSize
new6.17 KB

Hi,

I have added patch to this fixes. Please review it.

ggh’s picture

StatusFileSize
new7.18 KB

Updated the patch as it has some issues

amitgoyal’s picture

Status: Needs review » Reviewed & tested by the community

LGTM

amitgoyal’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @GGH and @pvsureshmca!

  • amitgoyal committed 1292457 on 8.x-1.x authored by GGH
    Issue #2933418 by pvsureshmca, GGH: Drupal coding standard issue
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.