Any plan for D 7?

CommentFileSizeAuthor
#9 workflow_fields_d7.patch28.56 KBJosh Benner

Comments

Encarte’s picture

+1

klonos’s picture

Title: Any plan for D 7? » Port Workflow Fields module to Drupal 7
Category: feature » task
Issue tags: +D7 porting, +port to d7, +d7 ports
earwax’s picture

+1

pav’s picture

+1

bakr’s picture

+1 - now that workflow module has been released for d7 ... please

infojunkie’s picture

Status: Active » Postponed

I currently have no plan to migrate this module to D7. If anyone wants to attempt it, please let me know.

eddie_c’s picture

I've made a start on this and created a sandbox for it here: http://drupal.org/sandbox/eddie_c/1680888. It's very much in development at the moment but I hope to get some more time to finish it off soon.

k.skarlatos’s picture

I am interested in this effort, and I am willing to help with testing at the least.

Josh Benner’s picture

StatusFileSize
new28.56 KB

Very rough first pass at porting to D7, not tested much, likely broken. Patch is diff from git 6.x-1.x branch.

k.skarlatos’s picture

it fails at patching the info file

patching file workflow_fields.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file workflow_fields.info.rej
patching file workflow_fields.install
patching file workflow_fields.js
patching file workflow_fields.module

Edit: thats probably due to drupal packaging info. I edited the file manually and the module installed ok.

Josh Benner’s picture

The patch is against what's in Git, not what Drupal packages, yeah.

This works as expected for me:

wget https://drupal.org/files/workflow_fields_d7.patch 
git clone --recursive --branch 6.x-1.x http://git.drupal.org/project/workflow_fields.git 
cd workflow_fields
patch -p1 < ../workflow_fields_d7.patch
k.skarlatos’s picture

after some basic testing i think that it works ok!
i have toggled visible and editable fields for specific roles and they work fine. Also it works as expected with workflow permissions and with field permissions module

Josh Benner’s picture

Status: Postponed » Needs review
eddie_c’s picture

Thanks Josh - you beat me to it! I have also done some basic testing and haven't found any problems - looking good.

infojunkie’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Committed to a new D7 branch with minor modifs. Please keep this issue closed and open new ones for bugs you may find.

Thanks to all contributors!

infojunkie’s picture

Also ported submodules to D7. Wrong thread, sorry!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klonos’s picture

Thanx!