Clean up code.

Comments

johnv created an issue. See original summary.

  • johnv committed d212ccf on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 9293474 on 8.x-1.x 
    Issue #2919482: Move Form elements from Action Form to TransitionElement

  • johnv committed d1ad323 on 8.x-1.x 
    Issue #2919482 by johnv: Better devel message

  • johnv committed 725bd34 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed f3160f3 on 8.x-1.x 
    git commit -m 'Issue #2919482: Reorder annotations'

  • johnv committed e11991b on 8.x-1.x 
    Issue #2919482: Clean code and sort functions in workflow.modules

  • johnv committed 9777407 on 8.x-1.x 
    Issue #2919482 by johnv: Clean code in WorkflowTransitionListBuilder.php

  • johnv committed 24ed04c on 8.x-1.x 
    Issue #2919482: Clean code in WorkflowTransitionElement.php

  • johnv committed 2f29f07 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed 829e33e on 8.x-1.x 
    Issue #2919482: clean code in workflow.module file

  • johnv committed e3d8345 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed 0ad17b6 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed e3feaf7 on 8.x-1.x 
    Issue #2919482: move constant WORKFLOW_MARK_STATE_IS_DELETED into class

  • johnv committed d939241 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 6d39869 on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 9e0f27a on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 18476fe on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 636c773 on 8.x-1.x 
    Issue #2919482: coding standards in workflow_access

  • johnv committed 05be2f6 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 03043a5 on 8.x-1.x 
    Issue #2919482: Clean code
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented

In file WorkflowManager.php, ths following warnings appear in my IDE:
- Class QueryFactory is deprecated,use \Drupal\Core\Entity\EntityStorageInterface::getQuery() instead
- Function dbupdate is deprecatated

  • johnv committed 0182da2 on 8.x-1.x 
    Issue #2919482 by johnv: Remove deprecated, unused WorkflowManager::...

  • johnv committed 39e8d81 on 8.x-1.x 
    Issue #2919482 by johnv: Remove deprecated function db_update from...

  • johnv committed a9c0846 on 8.x-1.x 
    Issue #2919482: Apdute PHPDoc for getWorkflowTransitionForm()

  • johnv committed 145f8cd on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to modules/

  • johnv committed c4d1223 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Element/

  • johnv committed 1cece51 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Entity/

  • johnv committed 985e292 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Plugin/

  • johnv committed 8c550de on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/

  • johnv committed 145a35d on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to workflow.api...

  • johnv committed 0a69e31 on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowTransitionElement.php

  • johnv committed f4d1dee on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowTransitionListController.php

  • johnv committed 0ad95aa on 8.x-1.x 
    Issue #2919482: Coding standards for info.yml files

  • johnv committed 760c096 on 8.x-1.x 
    Issue #2919482: Clean code: Usage of $node->workflow_transitions...

  • johnv committed 7a49f0a on 8.x-1.x 
    Issue #2919482: Clean code: code alignment

  • johnv committed 271f0fb on 8.x-1.x 
    Issue #2919482 by johnv: Clean code - separate workflow.devel.inc file

  • johnv committed 3ab7033 on 8.x-1.x 
    Issue #2919482 by johnv: Clean code - phpcs

  • johnv committed 818f79ad on 8.x-1.x 
    Issue #2919482: Clean code after code inspection

  • johnv committed 63f80777 on 8.x-1.x 
    Issue #2919482: Clean code - phpcs, shorthand ?? code

  • johnv committed f3654614 on 8.x-1.x 
    Issue #2919482: Clean code - workflow.views.inc

  • johnv committed 562ecabd on 8.x-1.x 
    Issue #2919482: Clean code - align annotations

  • johnv committed a1d49de4 on 8.x-1.x 
    Issue #2919482: phpcs workflow.module file

  • johnv committed 55b77c29 on 8.x-1.x 
    Issue #2919482: phpcs workflow.module file

  • johnv committed f4971fcd on 8.x-1.x 
    Issue #2919482: phpcs inheritdoc

  • johnv committed ca263ce2 on 8.x-1.x 
    Issue #2919482: phpcs - hook implementation documentation

  • johnv committed 6765e10e on 8.x-1.x 
    Issue #2919482: phpcs - hook implementation documentation

  • johnv committed 3afafe25 on 8.x-1.x 
    Issue #2919482: phpcs + update workflow.api.php
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Assigned: Unassigned » johnv
Status: Active » Postponed

  • johnv committed 8ca1fed8 on 8.x-1.x 
    Issue #2919482: phpstan WorkflowTypeForm.php

  • johnv committed 2c9fc015 on 8.x-1.x 
    Issue #2919482: clean code - better use of WorkflowInterface...

  • johnv committed cb792ef2 on 8.x-1.x 
    Issue #2919482: clean code - better use of (obsolete) inline @var...

  • johnv committed c549aac4 on 8.x-1.x 
    Issue #2919482: clean code - workflow_access.module

  • johnv committed 28474622 on 8.x-1.x 
    Issue #2919482: Clean code - sort functions in workflow.form.inc
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented

  • johnv committed 0ac9fb09 on 8.x-1.x 
    Issue #2919482: Clean code - better return code in...

  • johnv committed 079a876d on 8.x-1.x 
    Issue #2919482: Clean code - better naming of $entity_type

  • johnv committed f1a24a6f on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowItem.php

  • johnv committed d785f69f on 8.x-1.x 
    Issue #2919482: Clean code - better naming in workflow.field.inc

  • johnv committed db428308 on 8.x-1.x 
    Issue #2919482: Clean code - camelCase $entityType