Clean code [#2919482]

In file WorkflowManager.php, ths following warnings appear in my IDE:
- Class QueryFactory is deprecated,use \Drupal\Core\Entity\EntityStorageInterface::getQuery() instead
- Function dbupdate is deprecatated

Log in or register to post comments

Comment #23

27 July 2018 at 06:46

johnv committed 0182da2 on 8.x-1.x

Issue #2919482 by johnv: Remove deprecated, unused WorkflowManager::...

Log in or register to post comments

Comment #24

27 July 2018 at 07:15

johnv committed 39e8d81 on 8.x-1.x

Issue #2919482 by johnv: Remove deprecated function db_update from...

Log in or register to post comments

Comment #25

27 July 2018 at 07:20

johnv committed a9c0846 on 8.x-1.x

Issue #2919482: Apdute PHPDoc for getWorkflowTransitionForm()

Log in or register to post comments

Comment #26

27 July 2018 at 11:26

johnv committed 145f8cd on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to modules/

Log in or register to post comments

Comment #27

27 July 2018 at 11:29

johnv committed c4d1223 on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to src/Element/

Log in or register to post comments

Comment #28

27 July 2018 at 11:35

johnv committed 1cece51 on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to src/Entity/

Log in or register to post comments

Comment #29

27 July 2018 at 11:39

johnv committed 985e292 on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to src/Plugin/

Log in or register to post comments

Comment #30

27 July 2018 at 11:43

johnv committed 8c550de on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to src/

Log in or register to post comments

Comment #31

27 July 2018 at 11:47

johnv committed 145a35d on 8.x-1.x

Issue #2919482: Clean code: Add code_sniffer suggestions to workflow.api...

Log in or register to post comments

Comment #32

4 September 2018 at 16:33

johnv committed 0a69e31 on 8.x-1.x

Issue #2919482: Clean code - WorkflowTransitionElement.php

Log in or register to post comments

Comment #33

4 September 2018 at 16:51

johnv committed f4d1dee on 8.x-1.x

Issue #2919482: Clean code - WorkflowTransitionListController.php

Log in or register to post comments

Comment #34

2 November 2018 at 20:30

johnv committed 0ad95aa on 8.x-1.x

Issue #2919482: Coding standards for info.yml files

Log in or register to post comments

Comment #35

7 November 2018 at 23:35

johnv committed 760c096 on 8.x-1.x

Issue #2919482: Clean code: Usage of $node->workflow_transitions...

Log in or register to post comments

Comment #36

14 December 2018 at 10:30

johnv committed 7a49f0a on 8.x-1.x

Issue #2919482: Clean code: code alignment

Log in or register to post comments

Comment #37

4 June 2021 at 08:53

johnv committed 271f0fb on 8.x-1.x

Issue #2919482 by johnv: Clean code - separate workflow.devel.inc file

Log in or register to post comments

Comment #38

15 June 2021 at 08:21

johnv committed 3ab7033 on 8.x-1.x

Issue #2919482 by johnv: Clean code - phpcs

Log in or register to post comments

Comment #39

5 April 2023 at 20:41

johnv committed 818f79ad on 8.x-1.x

Issue #2919482: Clean code after code inspection

Log in or register to post comments

Comment #40

31 January 2024 at 15:52

johnv committed 63f80777 on 8.x-1.x

Issue #2919482: Clean code - phpcs, shorthand ?? code

Log in or register to post comments

Comment #41

1 February 2024 at 08:48

johnv committed f3654614 on 8.x-1.x

Issue #2919482: Clean code - workflow.views.inc

Log in or register to post comments

Comment #42

1 February 2024 at 13:05

johnv committed 562ecabd on 8.x-1.x

Issue #2919482: Clean code - align annotations

Log in or register to post comments

Comment #43

7 February 2024 at 12:54

johnv committed a1d49de4 on 8.x-1.x

Issue #2919482: phpcs workflow.module file

Log in or register to post comments

Comment #44

7 February 2024 at 13:19

johnv committed 55b77c29 on 8.x-1.x

Issue #2919482: phpcs workflow.module file

Log in or register to post comments

Comment #45

7 February 2024 at 13:25

johnv committed f4971fcd on 8.x-1.x
```
Issue #2919482: phpcs inheritdoc
```

Log in or register to post comments

Comment #46

7 February 2024 at 14:12

johnv committed 57230f0e on 8.x-1.x
```
Issue #2919482: phpcs
```

Log in or register to post comments

Comment #47

7 February 2024 at 15:51

johnv committed 6f152bda on 8.x-1.x
```
Issue #2919482: phpcs
```

Log in or register to post comments

Comment #48

7 February 2024 at 16:35

johnv committed 0f2d6d8f on 8.x-1.x
```
Issue #2919482: phpcs
```

Log in or register to post comments

Comment #49

8 February 2024 at 09:06

johnv committed ca263ce2 on 8.x-1.x

Issue #2919482: phpcs - hook implementation documentation

Log in or register to post comments

Comment #50

8 February 2024 at 09:06

johnv committed 30c2ef3d on 8.x-1.x
```
Issue #2919482: phpcs
```

Log in or register to post comments

Comment #51

8 February 2024 at 11:08

johnv committed 00a70da3 on 8.x-1.x
```
Issue #2919482: phpcs
```

Log in or register to post comments

Comment #52

8 February 2024 at 14:46

johnv committed 6765e10e on 8.x-1.x

Issue #2919482: phpcs - hook implementation documentation

Log in or register to post comments

Comment #53

9 February 2024 at 07:19

johnv committed c00a55a9 on 8.x-1.x
```
Issue #2919482: eslint
```

Log in or register to post comments

Comment #54

9 February 2024 at 08:54

johnv committed 3afafe25 on 8.x-1.x

Issue #2919482: phpcs + update workflow.api.php

Log in or register to post comments

Comment #55

johnv

Dutch

commented 9 February 2024 at 12:30

Assigned:	Unassigned	» johnv
Status:	Active	» Postponed

Log in or register to post comments

Comment #56

9 February 2024 at 13:07

johnv committed 8ca1fed8 on 8.x-1.x

Issue #2919482: phpstan WorkflowTypeForm.php

Log in or register to post comments

Comment #57

9 February 2024 at 13:36

johnv committed 2c9fc015 on 8.x-1.x

Issue #2919482: clean code - better use of WorkflowInterface...

Log in or register to post comments

Comment #58

9 February 2024 at 14:15

johnv committed cb792ef2 on 8.x-1.x

Issue #2919482: clean code - better use of (obsolete) inline @var...

Log in or register to post comments

Comment #59

9 February 2024 at 14:30

johnv committed c549aac4 on 8.x-1.x

Issue #2919482: clean code - workflow_access.module

Log in or register to post comments

Comment #60

19 February 2024 at 11:11

johnv committed 2e145b5b on 8.x-1.x
```
Issue #2919482: Clean code
```

Log in or register to post comments

Comment #61

5 March 2024 at 09:15

johnv committed 28474622 on 8.x-1.x

Issue #2919482: Clean code - sort functions in workflow.form.inc

Log in or register to post comments

Comment #62

johnv

Dutch

commented 7 March 2024 at 15:05

Log in or register to post comments

Comment #63

7 March 2024 at 15:05

johnv committed 9035805a on 8.x-1.x
```
Issue #2919482: Clean code
```

Log in or register to post comments

Comment #64

8 March 2024 at 11:19

johnv committed 0ac9fb09 on 8.x-1.x

Issue #2919482: Clean code - better return code in...

Log in or register to post comments

Comment #65

25 March 2024 at 11:40

johnv committed 079a876d on 8.x-1.x

Issue #2919482: Clean code - better naming of $entity_type

Log in or register to post comments

Comment #66

25 March 2024 at 15:26

johnv committed f1a24a6f on 8.x-1.x

Issue #2919482: Clean code - WorkflowItem.php

Log in or register to post comments

Comment #67

28 March 2024 at 08:32

johnv committed d785f69f on 8.x-1.x

Issue #2919482: Clean code - better naming in workflow.field.inc

Log in or register to post comments

Comment #68

15 April 2024 at 12:35

johnv committed db428308 on 8.x-1.x

Issue #2919482: Clean code - camelCase $entityType

Log in or register to post comments

Comment #69

12 June 2024 at 09:25

johnv committed 4dce2ce5 on 8.x-1.x

Issue #2919482: Add WorkflowTransitionInterface::getAttachedFields()

Log in or register to post comments

Comment #70

12 June 2024 at 09:26

johnv committed f0b5e33e on 8.x-1.x

Issue #2919482: Add better ternary code

Log in or register to post comments

Comment #71

12 June 2024 at 09:27

johnv committed ad4ab813 on 8.x-1.x

Issue #2919482: Shorter code in WorkflowTransitionRevertForm

Log in or register to post comments

Comment #72

12 June 2024 at 09:27

johnv committed efd2140c on 8.x-1.x

Issue #2919482: resort functions in WorkflowItem.php

Log in or register to post comments

Comment #73

13 June 2024 at 06:37

johnv committed 13621603 on 8.x-1.x

Issue #2919482: isolate Element::copyAttachedFields()

Log in or register to post comments

Comment #74

13 June 2024 at 06:54

johnv committed 04458d6d on 8.x-1.x

Issue #2919482: isolate Transition::updateEntityChangedTime()

Log in or register to post comments

Comment #75

4 July 2024 at 11:42

johnv committed dfc79660 on 8.x-1.x

Issue #2919482: Add null coalescing assignment operator

Log in or register to post comments

Comment #76

4 July 2024 at 11:45

johnv committed b96178c3 on 8.x-1.x

Issue #2919482: Add null coalescing assignment operator

Log in or register to post comments

Comment #77

20 February 2025 at 23:51

johnv committed 3caa0ec4 on 8.x-1.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #78

1 July 2025 at 15:12

johnv committed 180e4e1e on 2.0.x

Issue #2919482: Re-order functions in workflow.module file

Log in or register to post comments

Comment #79

1 July 2025 at 15:38

johnv committed 6ab24ad8 on 2.0.x

Issue #2919482: Move _workflow_info_fields() from workflow.module file...

Log in or register to post comments

Comment #80

3 July 2025 at 12:46

johnv committed 93ac8218 on 2.0.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #81

3 July 2025 at 14:32

johnv committed e4fac139 on 2.0.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #82

7 July 2025 at 07:44

johnv committed f19a8c07 on 2.0.x

Issue #2919482: Clean code - compatibility with workflow_notifications...

Log in or register to post comments

Comment #83

11 July 2025 at 14:05

johnv committed ee758728 on 2.1.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #84

johnv

Dutch

commented 11 July 2025 at 14:05

Version:

8.x-1.x-dev

» 2.1.4

Log in or register to post comments

Comment #85

11 July 2025 at 14:08

johnv committed 5710f05b on 2.1.x

Issue #2919482: Clean code - eslint - remove empty workflow_access.role....

Log in or register to post comments

Comment #86

11 July 2025 at 14:11

johnv committed 47ab8752 on 2.1.x

Issue #2919482: Clean code - phpstan - fix deprecation warning in...

Log in or register to post comments

Comment #87

11 July 2025 at 14:14

johnv committed ebf29148 on 2.1.x

Issue #2919482: Clean code - phpstan - fix deprecation warning in...

Log in or register to post comments

Comment #88

11 July 2025 at 14:16

johnv committed 333b089a on 2.1.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #89

11 July 2025 at 14:55

johnv committed c924173d on 2.1.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #90

11 July 2025 at 15:32

johnv committed daa5e99b on 2.1.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #91

16 July 2025 at 15:16

johnv committed 668aa09e on 2.1.x

Issue #2919482: Clean code - better readability

Log in or register to post comments

Comment #92

17 July 2025 at 12:52

johnv committed 4d2f42da on 2.1.x

Issue #2919482: Unify fieldset creation into central method

Log in or register to post comments

Comment #93

17 July 2025 at 12:57

johnv committed bb3223da on 2.1.x
```
Issue #2919482: clean code - cspell
```

Log in or register to post comments

Comment #94

17 July 2025 at 13:16

johnv committed e21f8ee4 on 2.1.x
```
Issue #2919482: clean code - phpcs
```

Log in or register to post comments

Comment #95

13 August 2025 at 10:03

johnv committed 7953e231 on 2.1.x

Issue #2919482: Clean code - better phpcs by improving interface...

Log in or register to post comments

Comment #96

17 August 2025 at 06:26

johnv committed c164fedd on 2.1.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #97

17 August 2025 at 06:45

johnv committed f696df0f on 2.1.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #98

18 August 2025 at 08:02

johnv committed 1a9e6e45 on 2.1.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #99

21 August 2025 at 13:20

johnv committed 771d8f46 on 2.1.x
```
Issue #2919482: Clean code - cspell
```

Log in or register to post comments

Comment #100

21 August 2025 at 13:34

johnv committed a19ec697 on 2.1.x

Issue #2919482: Clean code - add composer.json file

Log in or register to post comments

Comment #101

21 August 2025 at 13:37

johnv committed f0df082b on 2.1.x

Issue #2919482: Clean code - add composer.json file

Log in or register to post comments

Comment #102

21 August 2025 at 14:34

johnv committed fd68bd4e on 2.1.x

Issue #2919482 by bluegeek9: Add phpcs.xml.dist file

Log in or register to post comments

Comment #103

21 August 2025 at 15:01

johnv committed 400ae7ff on 2.1.x
```
Issue #2919482: Clean code - phpstan
```

Log in or register to post comments

Comment #104

21 August 2025 at 15:16

johnv committed 202e90e0 on 2.1.x
```
Issue #2919482: Clean code - phpcs
```

Log in or register to post comments

Comment #105

11 September 2025 at 06:11

johnv committed f4e16e48 on 2.1.x

Issue #2919482: Apply phpstan hints in WorkflowDevelHooks.php

Log in or register to post comments

Comment #106

11 September 2025 at 07:41

johnv committed 3636df01 on 2.1.x

Issue #2919482: Shorter code in WorkflowAccessHooks.php

Log in or register to post comments

Comment #107

11 September 2025 at 11:50

johnv committed 3d00850a on 2.1.x
```
Issue #2919482: clean code - phpcs
```

Log in or register to post comments

Comment #108

11 September 2025 at 12:17

johnv committed 9b5d84bc on 2.1.x
```
Issue #2919482: clean code - phpcs
```

Log in or register to post comments

Comment #109

17 September 2025 at 09:13

johnv committed 1db693ae on 2.1.x

Issue #2919482: clean code / CI: introduce...

Log in or register to post comments

Comment #110

17 September 2025 at 09:24

johnv committed 0e16f10e on 2.1.x

Issue #2919482: clean code / CI: unified Capitals in Forms

Log in or register to post comments

Comment #111

2 October 2025 at 13:00

johnv committed 0f5fe485 on 2.1.x

Issue #2919482: clean code / CI: add WorkflowTypeAttributeTrait to...

Log in or register to post comments

Comment #112

2 October 2025 at 20:19

johnv committed f86af842 on 2.1.x

Issue #2919482: clean code / CI: fix WorkflowTransitionExtendedTest.php

Log in or register to post comments

Comment #113

2 October 2025 at 20:23

johnv committed 3b55a550 on 2.1.x
```
Issue #2919482: clean code: cspell
```

Log in or register to post comments

Comment #114

2 October 2025 at 20:39

johnv committed 4045134b on 2.1.x
```
Issue #2919482: clean code: phpstan
```

Log in or register to post comments

Comment #115

2 October 2025 at 20:41

johnv committed 64d81b22 on 2.1.x
```
Issue #2919482: clean code: cspell
```

Log in or register to post comments

Comment #116

2 October 2025 at 21:00

johnv committed 693bd9a1 on 2.1.x
```
Issue #2919482: clean code: phpcs
```

Log in or register to post comments

Comment #117

3 October 2025 at 06:59

johnv committed 2d17cc7f on 2.1.x
```
Issue #2919482: clean code: phpcs
```

Log in or register to post comments

Comment #118

16 October 2025 at 07:10

johnv committed b48ccd36 on 2.1.x

Issue #2919482: clean code CI: faster fetching of workflow_current_user...

Log in or register to post comments

Comment #119

17 October 2025 at 08:43

johnv committed 562fdbe6 on 2.1.x

Issue #2919482: clean code CI: shorter code in WorkflowTransitionElement...

Log in or register to post comments

Comment #120

17 October 2025 at 08:48

johnv committed 704bab80 on 2.1.x

Issue #2919482: clean code CI: better reporting of attached fields in...

Log in or register to post comments

Comment #121

31 October 2025 at 10:48

johnv committed b8460493 on 2.1.x
```
[#2919482] Clean code - comment
```

Log in or register to post comments

Comment #122

31 October 2025 at 11:41

johnv committed c82c8c03 on 2.1.x
```
[#2919482] Clean code - phpcs
```

Log in or register to post comments

Comment #123

31 October 2025 at 12:14

johnv committed 80dccef5 on 2.1.x
```
[#2919482] Clean code - phpcs
```

Log in or register to post comments

Comment #124

1 December 2025 at 14:21

johnv committed 3d097631 on 2.1.x
```
[#2919482] clean code - cspell
```

Log in or register to post comments

Comment #125

1 December 2025 at 14:39

johnv committed 749d005f on 2.1.x
```
[#2919482] clean code - phpcs
```

Log in or register to post comments

Comment #126

13 March 2026 at 10:06

johnv committed 4909825d on 2.1.x

Issue #2919482: clean code: Add global namespace to built-in function...

Log in or register to post comments

Comment #127

13 March 2026 at 10:08

johnv committed ecc41f7c on 2.1.x

Issue #2919482: clean code: beter usability of workflow_debug()

Log in or register to post comments

Comment #128

6 May 2026 at 21:00

johnv committed 535eb30e on 2.1.x

Issue #2919482: clean code - add global namespace to count() calls

Log in or register to post comments

Comment #129

6 May 2026 at 21:33

johnv committed 0d12ed9e on 2.1.x
```
Issue #2919482: clean code - phpcs
```

Log in or register to post comments

Comment #130

8 May 2026 at 15:38

johnv committed 28c433b7 on 2.1.x

Issue #2919482: Introduce workflow_assert()

Log in or register to post comments

Comment #131

8 May 2026 at 15:42

johnv committed c38bae2d on 2.1.x

Issue #2919482: Introduce workflow_assert()

Log in or register to post comments

Comment #132

19 May 2026 at 21:10

johnv committed 3efbe0b4 on 2.1.x

Issue #2919482: Clean code - remove unnecessary @var statements, now...

Log in or register to post comments

Comment #133

19 May 2026 at 21:22

johnv committed a5572e09 on 2.1.x

Issue #2919482: Clean code - repair illogic naming in...

Log in or register to post comments

Comment #134

20 May 2026 at 18:56

johnv committed 68413926 on 2.1.x

Issue #2919482: Clean code - Add dependency injection

Log in or register to post comments

Clean code

Comments