Clean up code.

Comments

johnv created an issue. See original summary.

  • johnv committed d212ccf on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 9293474 on 8.x-1.x 
    Issue #2919482: Move Form elements from Action Form to TransitionElement

  • johnv committed d1ad323 on 8.x-1.x 
    Issue #2919482 by johnv: Better devel message

  • johnv committed 725bd34 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed f3160f3 on 8.x-1.x 
    git commit -m 'Issue #2919482: Reorder annotations'

  • johnv committed e11991b on 8.x-1.x 
    Issue #2919482: Clean code and sort functions in workflow.modules

  • johnv committed 9777407 on 8.x-1.x 
    Issue #2919482 by johnv: Clean code in WorkflowTransitionListBuilder.php

  • johnv committed 24ed04c on 8.x-1.x 
    Issue #2919482: Clean code in WorkflowTransitionElement.php

  • johnv committed 2f29f07 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed 829e33e on 8.x-1.x 
    Issue #2919482: clean code in workflow.module file

  • johnv committed e3d8345 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed 0ad17b6 on 8.x-1.x 
    Issue #2919482: Add function WorkflowManager::isWorkflowEntityType()

  • johnv committed e3feaf7 on 8.x-1.x 
    Issue #2919482: move constant WORKFLOW_MARK_STATE_IS_DELETED into class

  • johnv committed d939241 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 6d39869 on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 9e0f27a on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 18476fe on 8.x-1.x 
    Issue #2919482: Shorter code for workflow_url_get_workflow()

  • johnv committed 636c773 on 8.x-1.x 
    Issue #2919482: coding standards in workflow_access

  • johnv committed 05be2f6 on 8.x-1.x 
    Issue #2919482: Clean code

  • johnv committed 03043a5 on 8.x-1.x 
    Issue #2919482: Clean code
johnv’s picture

johnv
Primary language Dutch
commented

In file WorkflowManager.php, ths following warnings appear in my IDE:
- Class QueryFactory is deprecated,use \Drupal\Core\Entity\EntityStorageInterface::getQuery() instead
- Function dbupdate is deprecatated

  • johnv committed 0182da2 on 8.x-1.x 
    Issue #2919482 by johnv: Remove deprecated, unused WorkflowManager::...

  • johnv committed 39e8d81 on 8.x-1.x 
    Issue #2919482 by johnv: Remove deprecated function db_update from...

  • johnv committed a9c0846 on 8.x-1.x 
    Issue #2919482: Apdute PHPDoc for getWorkflowTransitionForm()

  • johnv committed 145f8cd on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to modules/

  • johnv committed c4d1223 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Element/

  • johnv committed 1cece51 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Entity/

  • johnv committed 985e292 on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/Plugin/

  • johnv committed 8c550de on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to src/

  • johnv committed 145a35d on 8.x-1.x 
    Issue #2919482: Clean code: Add code_sniffer suggestions to workflow.api...

  • johnv committed 0a69e31 on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowTransitionElement.php

  • johnv committed f4d1dee on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowTransitionListController.php

  • johnv committed 0ad95aa on 8.x-1.x 
    Issue #2919482: Coding standards for info.yml files

  • johnv committed 760c096 on 8.x-1.x 
    Issue #2919482: Clean code: Usage of $node->workflow_transitions...

  • johnv committed 7a49f0a on 8.x-1.x 
    Issue #2919482: Clean code: code alignment

  • johnv committed 271f0fb on 8.x-1.x 
    Issue #2919482 by johnv: Clean code - separate workflow.devel.inc file

  • johnv committed 3ab7033 on 8.x-1.x 
    Issue #2919482 by johnv: Clean code - phpcs

  • johnv committed 818f79ad on 8.x-1.x 
    Issue #2919482: Clean code after code inspection

  • johnv committed 63f80777 on 8.x-1.x 
    Issue #2919482: Clean code - phpcs, shorthand ?? code

  • johnv committed f3654614 on 8.x-1.x 
    Issue #2919482: Clean code - workflow.views.inc

  • johnv committed 562ecabd on 8.x-1.x 
    Issue #2919482: Clean code - align annotations

  • johnv committed a1d49de4 on 8.x-1.x 
    Issue #2919482: phpcs workflow.module file

  • johnv committed 55b77c29 on 8.x-1.x 
    Issue #2919482: phpcs workflow.module file

  • johnv committed f4971fcd on 8.x-1.x 
    Issue #2919482: phpcs inheritdoc

  • johnv committed ca263ce2 on 8.x-1.x 
    Issue #2919482: phpcs - hook implementation documentation

  • johnv committed 6765e10e on 8.x-1.x 
    Issue #2919482: phpcs - hook implementation documentation

  • johnv committed 3afafe25 on 8.x-1.x 
    Issue #2919482: phpcs + update workflow.api.php
johnv’s picture

johnv
Primary language Dutch
commented
Assigned: Unassigned » johnv
Status: Active » Postponed

  • johnv committed 8ca1fed8 on 8.x-1.x 
    Issue #2919482: phpstan WorkflowTypeForm.php

  • johnv committed 2c9fc015 on 8.x-1.x 
    Issue #2919482: clean code - better use of WorkflowInterface...

  • johnv committed cb792ef2 on 8.x-1.x 
    Issue #2919482: clean code - better use of (obsolete) inline @var...

  • johnv committed c549aac4 on 8.x-1.x 
    Issue #2919482: clean code - workflow_access.module

  • johnv committed 28474622 on 8.x-1.x 
    Issue #2919482: Clean code - sort functions in workflow.form.inc
johnv’s picture

johnv
Primary language Dutch
commented

  • johnv committed 0ac9fb09 on 8.x-1.x 
    Issue #2919482: Clean code - better return code in...

  • johnv committed 079a876d on 8.x-1.x 
    Issue #2919482: Clean code - better naming of $entity_type

  • johnv committed f1a24a6f on 8.x-1.x 
    Issue #2919482: Clean code - WorkflowItem.php

  • johnv committed d785f69f on 8.x-1.x 
    Issue #2919482: Clean code - better naming in workflow.field.inc

  • johnv committed db428308 on 8.x-1.x 
    Issue #2919482: Clean code - camelCase $entityType

  • johnv committed 4dce2ce5 on 8.x-1.x 
    Issue #2919482: Add WorkflowTransitionInterface::getAttachedFields()

  • johnv committed f0b5e33e on 8.x-1.x 
    Issue #2919482: Add better ternary code

  • johnv committed ad4ab813 on 8.x-1.x 
    Issue #2919482: Shorter code in WorkflowTransitionRevertForm

  • johnv committed efd2140c on 8.x-1.x 
    Issue #2919482: resort functions in WorkflowItem.php

  • johnv committed 13621603 on 8.x-1.x 
    Issue #2919482: isolate Element::copyAttachedFields()

  • johnv committed 04458d6d on 8.x-1.x 
    Issue #2919482: isolate Transition::updateEntityChangedTime()

  • johnv committed dfc79660 on 8.x-1.x 
    Issue #2919482: Add null coalescing assignment operator

  • johnv committed b96178c3 on 8.x-1.x 
    Issue #2919482: Add null coalescing assignment operator

  • johnv committed 3caa0ec4 on 8.x-1.x 
    Issue #2919482: Clean code - cspell

  • johnv committed 180e4e1e on 2.0.x 
    Issue #2919482: Re-order functions in workflow.module file

  • johnv committed 6ab24ad8 on 2.0.x 
    Issue #2919482: Move _workflow_info_fields() from workflow.module file...

  • johnv committed 93ac8218 on 2.0.x 
    Issue #2919482: Clean code - cspell

  • johnv committed e4fac139 on 2.0.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed f19a8c07 on 2.0.x 
    Issue #2919482: Clean code - compatibility with workflow_notifications...

  • johnv committed ee758728 on 2.1.x 
    Issue #2919482: Clean code - cspell
johnv’s picture

johnv
Primary language Dutch
commented
Version: 8.x-1.x-dev » 2.1.4

  • johnv committed 5710f05b on 2.1.x 
    Issue #2919482: Clean code - eslint - remove empty workflow_access.role....

  • johnv committed 47ab8752 on 2.1.x 
    Issue #2919482: Clean code - phpstan - fix deprecation warning in...

  • johnv committed ebf29148 on 2.1.x 
    Issue #2919482: Clean code - phpstan - fix deprecation warning in...

  • johnv committed 333b089a on 2.1.x 
    Issue #2919482: Clean code - cspell

  • johnv committed c924173d on 2.1.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed daa5e99b on 2.1.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed 668aa09e on 2.1.x 
    Issue #2919482: Clean code - better readability

  • johnv committed 4d2f42da on 2.1.x 
    Issue #2919482: Unify fieldset creation into central method

  • johnv committed bb3223da on 2.1.x 
    Issue #2919482: clean code - cspell

  • johnv committed e21f8ee4 on 2.1.x 
    Issue #2919482: clean code - phpcs

  • johnv committed 7953e231 on 2.1.x 
    Issue #2919482: Clean code - better phpcs by improving interface...

  • johnv committed c164fedd on 2.1.x 
    Issue #2919482: Clean code - cspell

  • johnv committed f696df0f on 2.1.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed 1a9e6e45 on 2.1.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed 771d8f46 on 2.1.x 
    Issue #2919482: Clean code - cspell

  • johnv committed a19ec697 on 2.1.x 
    Issue #2919482: Clean code - add composer.json file

  • johnv committed f0df082b on 2.1.x 
    Issue #2919482: Clean code - add composer.json file

  • johnv committed fd68bd4e on 2.1.x 
    Issue #2919482 by bluegeek9: Add phpcs.xml.dist file

  • johnv committed 400ae7ff on 2.1.x 
    Issue #2919482: Clean code - phpstan

  • johnv committed 202e90e0 on 2.1.x 
    Issue #2919482: Clean code - phpcs

  • johnv committed f4e16e48 on 2.1.x 
    Issue #2919482: Apply phpstan hints in WorkflowDevelHooks.php

  • johnv committed 3636df01 on 2.1.x 
    Issue #2919482: Shorter code in WorkflowAccessHooks.php

  • johnv committed 3d00850a on 2.1.x 
    Issue #2919482: clean code - phpcs

  • johnv committed 9b5d84bc on 2.1.x 
    Issue #2919482: clean code - phpcs

  • johnv committed 1db693ae on 2.1.x 
    Issue #2919482: clean code / CI: introduce...

  • johnv committed 0e16f10e on 2.1.x 
    Issue #2919482: clean code / CI: unified Capitals in Forms

  • johnv committed 0f5fe485 on 2.1.x 
    Issue #2919482: clean code / CI: add WorkflowTypeAttributeTrait to...

  • johnv committed f86af842 on 2.1.x 
    Issue #2919482: clean code / CI: fix WorkflowTransitionExtendedTest.php

  • johnv committed 3b55a550 on 2.1.x 
    Issue #2919482: clean code: cspell

  • johnv committed 4045134b on 2.1.x 
    Issue #2919482: clean code: phpstan

  • johnv committed 64d81b22 on 2.1.x 
    Issue #2919482: clean code: cspell

  • johnv committed 693bd9a1 on 2.1.x 
    Issue #2919482: clean code: phpcs

  • johnv committed 2d17cc7f on 2.1.x 
    Issue #2919482: clean code: phpcs

  • johnv committed b48ccd36 on 2.1.x 
    Issue #2919482: clean code CI: faster fetching of workflow_current_user...

  • johnv committed 562fdbe6 on 2.1.x 
    Issue #2919482: clean code CI: shorter code in WorkflowTransitionElement...

  • johnv committed 704bab80 on 2.1.x 
    Issue #2919482: clean code CI: better reporting of attached fields in...

  • johnv committed b8460493 on 2.1.x 
    [#2919482] Clean code - comment

  • johnv committed c82c8c03 on 2.1.x 
    [#2919482] Clean code - phpcs

  • johnv committed 80dccef5 on 2.1.x 
    [#2919482] Clean code - phpcs

  • johnv committed 3d097631 on 2.1.x 
    [#2919482] clean code - cspell

  • johnv committed 749d005f on 2.1.x 
    [#2919482] clean code - phpcs

  • johnv committed 4909825d on 2.1.x 
    Issue #2919482: clean code: Add global namespace to built-in function...

  • johnv committed ecc41f7c on 2.1.x 
    Issue #2919482: clean code: beter usability of workflow_debug()

  • johnv committed 535eb30e on 2.1.x 
    Issue #2919482: clean code - add global namespace to count() calls

  • johnv committed 0d12ed9e on 2.1.x 
    Issue #2919482: clean code - phpcs

  • johnv committed 28c433b7 on 2.1.x 
    Issue #2919482: Introduce workflow_assert()

  • johnv committed c38bae2d on 2.1.x 
    Issue #2919482: Introduce workflow_assert()