Closed (fixed)
Project:
Workflow
Version:
7.x-2.0-beta7
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Dec 2013 at 09:48 UTC
Updated:
16 Jan 2014 at 11:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
matthijsThe patch as promised...
Comment #2
johnvThanks for this wonderful patch.
Please find my revised version attached:
1- IMO we can now remove hook_menu(), in favour of hook_menu_alter();
[EDIT] Wrong: we still need this for the Workflow Node module.
2- In hook_menu_alter(), you add the 'workflow' tab twice:
-- what is the function of the first ('admin ui')? Where can I see its usage? (Happy to leave it in, oif it works for you)
-- the second did not use $entity_position, generating an error on a taxonomy_term.
[EDIT] I think I'll move hook_menu to Workflow Node, and hook_menu_alter to Workflow Field, keeping a comment in workflow.module file.
Comment #3
johnvI committed this here.
The hook_menu could be moved to workflownode.module, and the hook_menu_alter could be moved to workflowfield.module, but this seems confusing. Thanks.
Comment #4
johnvFor a complete implementation, workflow_admin_paths_alter(&$paths) needs a rework, too.
ATM it doesn't work at all. See the related issue.
Comment #5
matthijsHi,
Thanks for your quick review/commit.
The "admin ui" is used by Entity API for its own Admin UI, see https://drupal.org/node/1021576
Comment #6
johnvThis can be closed, since I've re-opened the other issue.