First of all thank you for contributing this module. It meets the need I had for a project. Upon review I noticed quite a few things that do not follow the Drupal coding standards and best practices. I would like to offer a patch that addresses these issues.

This patch also addresses this issue [Workbench moderation buttons should check revisioning status before overriding form submit buttons.](https://www.drupal.org/node/2130139)

CommentFileSizeAuthor
workbench_moderation_buttons-coding-standards-2088327-0.patch5.63 KBkepford

Comments

sebastix’s picture

sebastix
Primary language Dutch
Location Breda, Netherlands
commented

I get this error:

Fatal error: Call to undefined function workbench_moderation_node_moderated() in ../workbench_moderation_buttons/workbench_moderation_buttons.module on line 16

I'm using workbench moderation version 7.x-1.3 (https://www.drupal.org/project/workbench_moderation).

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Works with 7.x-1.x-dev

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs work

Sebasian: You should upgrade to Workbench Moderation 7.x-1.x-dev until 1.4 is released, there are several important fixes in -dev that you could benefit from. This patch was tested against the WM -dev release.

FYI the patch itself needs a little tweaking - the module is called "Workbench Moderation", the word "weight" is misspelled as "wieght", and there's no need to specify a "version" line in the info file, that's automatically added by the package manager.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Project: » Workbench Moderation Buttons

Moved over to new full project version.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs work » Fixed

Fixed per http://cgit.drupalcode.org/workbench_moderation_buttons/commit/?id=13585ff

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.