On module install, default transitions are included as permissions for unchanged states.

Desired outcome:

Only actual state changes should be available as actions / permissions.

CommentFileSizeAuthor
#7 2651078-transition-help-text.patch987 bytesCrell
#3 Screen Shot 2016-01-15 at 2.06.52 PM.png32.05 KBagentrickard
#2 Screen Shot 2016-01-15 at 2.04.24 PM.png34.97 KBagentrickard
Screen Shot 2016-01-15 at 2.01.47 PM.png64.26 KBagentrickard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard created an issue. See original summary.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
FileSize
Screen Shot 2016-01-15 at 2.04.24 PM.png34.97 KB

Screen shot of default transition states

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
FileSize
Screen Shot 2016-01-15 at 2.06.52 PM.png32.05 KB

Ideally, I would also not be allowed to select the same state as a transition endpoint in the UI.

Do not allow Draft to be selected in both lists.

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented

That's actually deliberate. There are cases where you DO want to keep the state the same, and others where you want to forbid it from being kept. For example, on some sites you may want to allow a published node to be kept published after a trivial save. On others, you want to force any changes of a Published node to go to Draft. The way we decided made most sense is to allow, and include, "self transitions" (transitions from a state to the same state), as that meant everything else still worked without any special casing. It's just another part of the existing configuration.

Is there a better way we could communicate that in the UI?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

I think that's a case for documentation and perhaps Tour.

I jumped in without reading anything.

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Component: User interface » Documentation
Category: Bug report » Task
Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Assigned: Unassigned » agentrickard
Status: Active » Needs review
FileSize
2651078-transition-help-text.patch987 bytes

Here's some help text. Easy peasy to merge. Ken, any suggested edits?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Needs review » Reviewed & tested by the community

I get it now. Text is acceptable.

  • Crell committed 5789f0e on 8.x-1.x 
    Issue #2651078 by Crell: Default transitions include unchanged states...
Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Reviewed & tested by the community » Fixed

Merged. Thanks, Ken.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.