Updating code is a generic wf_job action and so the logic should sit in that sub module, rather than creating a dependency on the wf_jenkins module, which may not be used.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | wf-update-code-logic-2017409-3.patch | 8.3 KB | skwashd |
| #1 | wf-move-update-code-logic-2017409-1.patch | 13.42 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedThe update code logic is now on wf_job.
There a new rules event that is fired by the 'Update code' submit handler, now wf_job have 3 roles related with it, the ones that were in wf_jenkins and a new one called wf_job_update_code_submit.
In wf_jenkins i've created a rules action that receives the job object and handle the code update.
Comment #2
skwashd commentedThis patch doesn't apply cleanly. Please reroll it.
Comment #3
skwashd commentedLuiz provided me with the diff directly. It has been applied and committed. Attached is a copy of the patch for the record.