We're getting feedback that "All" is better placed at the end of the topic list.

CommentFileSizeAuthor
#5 webpush-selection-for-all-at-the-end-3056374-5.patch1.21 KBefpapado
#4 webpush-selection-for-all-at-the-end-3056374-4.patch858 bytessvenryen
#2 webpush-selection-for-all-at-the-end-3056374-2.patch742 bytessvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new webpush-selection-for-all-at-the-end-3056374-2.patch742 bytes
svenryen’s picture

svenryen commented
Status: Active » Needs review
svenryen’s picture

svenryen commented
StatusFileSize
new webpush-selection-for-all-at-the-end-3056374-4.patch858 bytes

I mixed up files for two patches. Here's a proper patch.

efpapado’s picture

efpapado commented
Title: Move "All" option to the end » Change position of "All" option
StatusFileSize
new webpush-selection-for-all-at-the-end-3056374-5.patch1.21 KB

I'm a bit sceptical about that. I guess having it in the end is as reasonable as having it in the beginning. How about adding classes to the wrapping <label> and let the frontend handle it? Or even better adding another alter hook?

svenryen’s picture

svenryen commented
Status: Needs review » Needs work

I second the alter hook. Good idea! When it comes to position, I have a slight bias towards placing it at the end, as the user may want to review what other options are available before they resort to choosing every option.