I don't actually use this module; I just ran into the issue when looking at /tracker. But I thought it warranted an issue as its uninstall apparently empties out the variables table. Looks like it was reported a year and a half ago and no response from the maintainer. I wouldn't normally report a module bug in the webmaster's queue but, since this has nasty effects outside of the scope of the module, and since the maintainer isn't addressing it, I thought I'd bring it up to see what can be done.

See #879706: Uninstall w/mods uninstall crashes database

Michelle

Comments

patrickd’s picture

patrickd commented
Status: Active » Fixed

I wanted to help on this, so I hope I didn't do anything forbidden :>

I temporarily added myself as co-maintainer
Made the change as mentioned in https://drupal.org/node/879706#comment-4010116

diff --git a/chatroll.install b/chatroll.install
index 9cbcf2a..b4c695f 100644
--- a/chatroll.install
+++ b/chatroll.install
@@ -9,7 +9,7 @@ function chatroll_uninstall() {
   global $conf;
   foreach (array_keys($conf) as $key) {
     // Find variables that have the 'chatroll_' module prefix
-    if (strpos($key, 'chatroll_') == 0) {
+    if (strpos($key, 'chatroll_') === 0) {
       variable_del($key);
     }
   }
patrickd@patrickd-netbook:~/Desktop/chatroll$ git commit -am "Issue #879706 by m1n0, Lee-vit-Over, Michelle: Fixed bug causing the variables table to truncate on uninstall."

Did a short install -> uninstall test -> drupal is still alive.
Pushed the changes and created a new release.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Thanks for that but I don't deserve commit credit. LOL! All I did was point at the problem and then forgot about it.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I know that was done with the best of intentions, but IMO it's inappropriate to change someone else's project like this.

You could have used the "unsupported" project process or e-mailed the maintainer, but in the future please propose an idea and wait for a few days to get comments on it before doing it.

patrickd’s picture

patrickd commented

Yes, I understand that
I wouldn't have done that hasty it if the reported issue weren't from August 11, 2010 without any reaction of the maintainer.

But I'll definitely take more care of this next time, sorry! :/

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@greggles: Normally I would agree with you but, in this case, it was a matter of adding one character to the module in order to prevent the module from hosing peoples' sites. I certainly wouldn't want to see taking over projects to fix thing to become the norm by any means but, in this case, given the age of the issue and the severity of it and the minorness of the fix, I think it was an ok exception.

Michelle

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Given the age of the issue it could have waited 2 more weeks for the unsupported project process or at least 2 more days for "I propose to do X, I will do it if nobody complains" in this queue.

People feel very strongly that their projects are theirs and we shouldn't mess with that without following our processes. it's a great way to alienate people and make them not want to work in our community. Even when we do follow the process it alienates folks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.