Adding New Group and Hierarchical Select Module

That's one module I don't use. I guess I'll have to download it and try to learn it.

I downloaded the most current HS and used it out of the box with no trouble. However, considering that no one else has reported any kind of problem with WL in this area, I would have to think it is a HS problem. Taxonomy_form_term is a core function that we have been using for some time.

Moving to HS. Please check the version to make sure the issue is for the correct one.

When just using HS, the taxonomy term form works just fine, including adding parents through HS. So it's unlikely HS is at fault.

It's probably due to the fact that I'm probably the only module using a severely under-documented Drupal 6 core feature: I set the taxonomy_override_selector variable.

NancyDru: try enabling the Hierarchical Select Taxonomy module. Without that module, it's impossible to reproduce this problem I think. Back to you :)

I did enable it. It was fairly obvious that I would need it. I have no idea what that variable does, However, I was unable to reproduce this problem.

NancyDru: How do you use the taxonomy_form_term form? Do you call it to a new menu callback? Are you including the file in which it exists from within the form definition function?

  // Group operations.
  $items['weblinks/group/add'] = array(
    'title' => 'Add a group',
    'page callback' => '_weblinks_group_operations',
    'page arguments' => array(2),
    'access callback' => 'weblinks_group_access',
    'type' => MENU_LOCAL_TASK,
    );

Calls...

function _weblinks_group_operations($op, $tid = NULL) {
  if (!weblinks_group_access()) {
    drupal_access_denied();
  }

  // Force admin theme.
  global $custom_theme;
  $custom_theme = variable_get('admin_theme', '0');
  drupal_add_css(drupal_get_path('module', 'system') .'/admin.css');
  drupal_add_css(drupal_get_path('module', 'weblinks') .'/weblinks.admin.css');

  drupal_set_title(t('Group !op', array('!op' => $op)));

  include_once(drupal_get_path('module', 'taxonomy') .'/taxonomy.admin.inc');

  $vocabulary = taxonomy_vocabulary_load(_weblinks_get_vocid());
  $_REQUEST['destination'] = 'weblinks';

  switch ($op) {
    case 'add':
      return drupal_get_form('taxonomy_form_term' , $vocabulary);

    case 'edit':
      return taxonomy_admin_term_edit($tid);
  }
}

and

function weblinks_form_alter(&$form, &$form_state, $form_id) {
  switch ($form_id) {
    case 'taxonomy_form_term':
      // Is this for our vocabulary?
      if ($form['#vocabulary']['vid'] != _weblinks_get_vocid()) {
        return '';
      }
      $form['identification']['#weight'] = -10;
      $form['identification']['#collapsible'] = FALSE;
      $form['identification']['name']['#title'] = t('Group name');
      $form['identification']['name']['#description'] = t('The name of this group.');
      $form['identification']['description']['#title'] = t('Group description');
      $form['identification']['description']['#description'] = t('A description of the group, to be displayed on web links pages and forms.');

      $form['advanced']['#weight'] = -5;
      $form['advanced']['parent']['#description'] = t('Parent groups.');
      $form['advanced']['weight']['#description'] = t('Groups are displayed in ascending order by weight.');
      unset($form['advanced']['relations']);
      unset($form['advanced']['synonyms']);

      if (isset($form['taxonomy_image'])) {
        $form['taxonomy_image']['#title'] = t('Group image');
        $form['taxonomy_image']['new_image']['path']['#description'] = t('The image file you wish to associate this group.');
      }

      break;
  } // End switch form_id.
}

Hierarchical Select detects which file belongs to the currently active menu item. It assumes the form definition function lives in there. This is a file of the Web Links module.

HS loads this file during AHAH callbacks and then calls the form definition function — because it assumes this function is part of the file it just loaded.

In this case, that's no longer true, because you are rerouting users to a different form. Easy enough to work around since recently though. merlinofchaos caused similar problems with his CTools Delegator module. So he added a new $form_state key: $form_state['form_load_files']. This is obviously supposed to be an array. So check if it is set, if it is, append to it, otherwise, create it.
Do that, and all will be good :)

Append what to it? I don't use Ctools, so it will not be set. Everything works fine for me now.

Append drupal_get_path('module', 'taxonomy') .'/taxonomy.admin.inc' to it, like this:

if (!isset($form_state['form_load_files'])) {
  $form_state['form_load_files'] = array();
}
$form_state['form_load_files'][] = drupal_get_path('module', 'taxonomy') .'/taxonomy.admin.inc';

Does this go in the original form call or in the form_alter?

form_alter() I suppose, because you can only access $form_state from there …

Okay, that's kind of what I thought.

@gumdrop: Since I cannot reproduce this, please try the attached patch.

If I could reproduce this error it would help a lot.

No, and don't use Panels either - and I'm seeing all kinds of problems when using it, so I am unlikely to use it on my personal sites. But that statement also makes it sound like this is either a Panels or Ctools problem, doesn't it?

Moving to cTools.

I'd appreciate it if you didn't move stuff to my queue on a wild ass guess. There's not a single shred of evidence from anything in here that ctools is even involved. NOthing in the error suggests ctools and it's not even in a place ctools does anything. The only reason it's even brought up is due to a totally different patch that gets CTools and HS working together.

Please show some evidence or actual logical reasoning rather than just shoving this stuff off on me.

And that kind of response is why I want nothing to do with Ctools (or even Views) if I can help it.

Oh you're right.

It should be happy that you sent an issue over to me with no evidence. Of course it's my fault. Not that the error message suggests CTools is involved, nor the path, but of course, it must be CTools' fault. After all, it's installed on the site.

And with this sound deductive reasoning in place, I am now obligated to go fix it. That and the 25,324 other random issues that MUST also be CTools' fault.

What the heck do you have against me, anyway? The only thing I know about you (I went and looked for your name in the queues just to check) is that I asked you why realname does something and you answered with a bunch of code that didn't tell me anything about why, and then disappeared when I asked for clarification. So I was never able to provide you anything, even though I tried to. Yet somehow you seem to be bitter at me.

I assume RealName module will continue to not work with Page Manager, so I will put a note in my known issues that it will never happen, and to advise picking one or the other.

And since you want nothing to do with Views, please, please please,

1) uninstall it,
2) get rid of any modules you have with Views support.

I certainly don't want you to have to be further burdened by my work.

It's not your work, it's the way you have treated me since the first issue I ever filed with you. You have belittled me time and time again, including calling me stupid (literally) in public forums. I transferred this issue over because the OP suggested it was with your module. No one else has seen this problem with this module and even with HS installed (which I only did to try to reproduce this problem) I could not get it to happen. The only other modules involved were Panels and Ctools, neither of which I have; therefore I had to agree with the OP.

As for the RealName issue, I never saw an answer that made any sense to me. I will go back and see if I can find the answer you refer to and see if it is written for such a stupid person as me to understand. I continually find, as do many others who have confided in me, that your documentation seems to be written for someone who already knows what they are doing rather than someone approaching your modules for the first time. And then when we ask questions we get treated like insignificant dunces.

Neither of us has to like everyone in the Drupal community, but we should all be treating each other with a basic respect. I greatly respect your work and your knowledge, but you have treated me with contempt on nearly every occasion for two years now.

You're welcome.