The weblinks embed and weblinks filter modules both add settings to the filter form when configuring the input filters at admin/settings/filters/x/configure. This is done in hook_settings(). However, both functions use the same fieldset name 'link' which means that if you have both of the filters ticked for a specific input then only one fieldset is shown because one overwrites the other.

A simple fix is to change the array key from 'link' to 'link_embed' in weblinks_embed_settings().

CommentFileSizeAuthor
#2 2599258_1.weblinks_embed_change_form_key.d6.patch997 bytesjonathan1055
#2 d6 filter form with filter and embed - with fix.jpg504.74 KBjonathan1055
#2 d6 filter form with filter and embed - before.jpg446.1 KBjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new d6 filter form with filter and embed - before.jpg446.1 KB
new d6 filter form with filter and embed - with fix.jpg504.74 KB
new 2599258_1.weblinks_embed_change_form_key.d6.patch997 bytes

Here are screen shots showing before and after, and a patch

GStegemann’s picture

GStegemann commented
Status: Needs review » Reviewed & tested by the community

Tested and works.

Wondering that this problem was not discovered earlier.

  • jonathan1055 committed ed6fc9d on 6.x-2.x 
    Issue #2599258 by jonathan1055: Weblinks-embed and Weblinks-filter...
jonathan1055’s picture

jonathan1055 commented
Status: Reviewed & tested by the community » Fixed

Yes I was surprised that it had not been noticed before.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.