Follow up from #2864523: Exposing filters on webform required fields and entity selects.

Namely: drop-downs of taxonomy terms (which are not required) do not get an '- select -' or 'Any' type option as you would normally expect in such cases.

CommentFileSizeAuthor
#6 add_empty_option_to_exposed_select-2872172-6.patch734 bytesalit
#2 2872172-select-required-2.patch2.11 KBbucefal91

Comments

bucefal91 created an issue. See original summary.

bucefal91’s picture

bucefal91 commented
Status: Active » Needs review
StatusFileSize
new 2872172-select-required-2.patch2.11 KB

Here's a patch. Right now it applies to "select" webform element type. Stella, I saw you were using "webform_entity_select" element type (at least I infer that from the fact that you were using dropdowns for taxonomy terms).

It should be a rather simple job of expanding the existing select machinery onto this new select-derivative.

  • bucefal91 committed c49b0e6 on 8.x-5.x 
    Issue #2872172 by stella, bucefal91: Adding 'all' option to exposed...
bucefal91’s picture

bucefal91 commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alit’s picture

alit commented
StatusFileSize
new add_empty_option_to_exposed_select-2872172-6.patch734 bytes

Hi guys, thanks for a nice module.

The attached patch adds missing empty option to the common filter "webform_submission_field_filter" that is used for term references.