Comments

knalstaaf created an issue. See original summary.

joseph.olstad’s picture

Status: Active » Needs work

look at the related issue for ideas for a possible solution.

anton.shloma’s picture

Status: Needs work » Needs review
StatusFileSize
new3.19 KB

I did a similar solution as here https://www.drupal.org/node/1859860
But now it affects all the web-form blocks on the page (of any kind)
Hope it will help.

However js_alter is not a good place to fix the issue :) Could be better to fix the source of the node_view behavior here, but it will take lot of time to do refactoring of this.. so for the quick win here is a patch

qzmenko’s picture

Status: Needs review » Reviewed & tested by the community

Works good for me

joseph.olstad’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

eddi86’s picture

The patch dosn't check if translation module is enabled. I used 4.11. with entity_translation and don't use translation synchronisation. So Webforms with conditionals fields run into an error because:

Fatal error: Call to undefined function translation_node_get_translations() in .../webform_localization/webform_localization.module on line 1328

joseph.olstad’s picture

Status: Closed (fixed) » Needs review

ok, will review this over the weekend.

joseph.olstad’s picture

StatusFileSize
new2.27 KB

Thanks for the heads up @eddi86 , I have taken this into consideration, simply checking for translation enabled isn't enough, because multiple content types are possible, multiple translation modes possible.

joseph.olstad’s picture

Priority: Normal » Critical
joseph.olstad’s picture

slight optimisation

joseph.olstad’s picture

StatusFileSize
new2.39 KB

add description

  • joseph.olstad committed 76eb0e5 on 7.x-4.x authored by eddi86
    Issue #2829894 by joseph.olstad, anton.shloma, eddi86, qzmenko:...
joseph.olstad’s picture

Status: Needs review » Fixed

should be good now let me know

joseph.olstad’s picture

Status: Fixed » Active

sorry, I introduced a new regression
fix comming shortly, new release as well.

joseph.olstad’s picture

Status: Active » Needs review
StatusFileSize
new1.06 KB

review patch quickly

joseph.olstad’s picture

revert patch for this, deciding whether or not to revert, more time for review.

  • joseph.olstad committed fa3a892 on 7.x-4.x
    Issue #2829894 by joseph.olstad, anton.shloma, eddi86, qzmenko:...
joseph.olstad’s picture

ok, there's maybe still an issue with this, if using entity_translation the webform as a block conditionals might not be working (needs testing).
I have openned a new issue for that.
#2970924: webforms as a block conditionals, confirm this is working for entity_translation /field translation enabled webforms.

joseph.olstad’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Pipuch’s picture

StatusFileSize
new17.89 KB
new17.77 KB

Hello
I've had a problem with showing the conditions, but the patch #18 has fixed it. Thanks.
I have a another problem :(,When I created content via content type webform is OK, but when i create node with my own content type with webform function, I have a problem visibility webform in second language.
(Expose webform component strings suitable for translation and Keep a single webform across a translation set - is checked)
form component visible
second language-form component not visible