The number input type needs to be added to the list of field types that are acted upon.

CommentFileSizeAuthor
#3 webform_hints-add-number-input-hints-2095947-0.patch660 bytesadamzimmermann
#1 webform_hints-add-number-input-hints-2095947-0.patch830 bytesadamzimmermann

Comments

adamzimmermann’s picture

adamzimmermann commented
StatusFileSize
new webform_hints-add-number-input-hints-2095947-0.patch830 bytes

Patch attached.

guschilds’s picture

guschilds commented
Status: Active » Needs work

A few problems with this patch:

  • In the diff of your patch, the line being removed containers 'number' in the array, which was never in the module's code. I'm guessing that came when testing locally.
  • The full path made it in there, "a/sites/all/modules/contrib/webform_hints/webform_hints.module", which causes it to fail when I attempt to apply it unless I have the same file structure and my patch in the right place. Perhaps create the patch from within the module directory.

Also, please mark an issue as 'needs review' when a patch needs review.

Marking as 'needs work', but I did test the addition of 'webform_number' and confirmed it works. Feel free to just commit that addition and mention it here so that folks are aware of that and don't attempt to use the patch in #1.

adamzimmermann’s picture

adamzimmermann commented
Status: Needs work » Needs review
StatusFileSize
new webform_hints-add-number-input-hints-2095947-0.patch660 bytes

Good catch on the numbers thing. I thought I had guessed right the first time and then committed that last week, but then it screwed up the diff.

re: paths - My bad. Sorry about that.

I am committing the changes for an upcoming release and attaching a patch for the interim.

guschilds’s picture

guschilds commented
Status: Needs review » Fixed

Patch looks good and works well. Saw you've committed it, so marking this as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.