Field labels should be hidden with css, not removed. Labels are important for accessibility. Screen reading software relies on them.

This is a great project. I hope it becomes a full-fledged module.

Thanks
-Cameron

CommentFileSizeAuthor
#2 webform_hints_6-hidden_labels_fixed.png50.92 KBguschilds
#2 webform_hints_7-hidden_labels_fixed.png56.54 KBguschilds

Comments

chrisfree’s picture

chrisfree commented
Assigned: Unassigned » chrisfree
Status: Active » Needs review

Hey Cameron,

Great observation. I just pushed up a commit to the 7.x branch that adjusts this. I'll get this rolled into the 6.x branch shortly. Thanks for pointing this out!

http://drupalcode.org/sandbox/chrisfree/1128558.git/commitdiff/4dd48b2

Chris

guschilds’s picture

guschilds commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new webform_hints_7-hidden_labels_fixed.png56.54 KB
new webform_hints_6-hidden_labels_fixed.png50.92 KB

Thanks, Cameron.

An adjustment by chrisfree was made to the 6.x branch as well: http://drupalcode.org/sandbox/chrisfree/1128558.git/commitdiff/e5b018a90...

The labels now remain in the HTML for accessibility, but are hidden appropriately in both branches.

Screenshots are attached.

Gus

eusonic’s picture

eusonic commented

Awesome! I'm super impressed by the quick action on this.

Thanks
-Cameron

guschilds’s picture

guschilds commented
Status: Reviewed & tested by the community » Closed (fixed)

Closing as fixed. The code is in both the 6.x and 7.x branches.

Please re-open if an issue is found with this portion of functionality.

Thanks again for bringing this up!