I'm trying to redirect the form Submission dynamically so i tried using the php code at the input format. It didn't work so i checked and sow at webform.module:1882 the redirection handling. There's no evaluation of the php code anywhere. I believe it's a bug so please tell me if it's not and if it's supposed the be evaluated before or is there any other way to redirect dynamically.

Comments

shua’s picture

shua commented
Category: support » bug
Status: Active » Needs review

here's my fix on webform.module. I know it's ugly but it works: 

@@ -1877,7 +1877,9 @@
   if (variable_get('webform_debug', 0) >= 1) {
     watchdog('webform', t('Submission posted to %title. <a href="!url">Results</a>. !details', array('%title' => $node->title, '!url' => url('node/'. $node->nid .'/submission/'. $sid), '!results' => "<br />\n<pre>". htmlentities(print_r($form_state['values'], TRUE)) .'</pre>')));
   }
-
+  if($node->format==3) {
+  	$node->webform['confirmation'] = drupal_eval($node->webform['confirmation']);
+  }
   // Check confirmation field to see if redirect should be to another node or a message.
   if (isset($form_state['values']['submission'])) {
     drupal_set_message(t('Submission updated.'));
quicksketch’s picture

quicksketch
he/him
commented
Category: bug » support
Status: Needs review » Active

It looks like PHP code is only executed on display of the summary, not when determining where the summary should be shown. You can see that Webform uses check_markup in template_preprocess_webform_confirmation():

  $vars['confirmation_message'] = check_markup($vars['node']->webform['confirmation'], $vars['node']->webform['confirmation_format'], FALSE);

Note that check_markup() is the proper way for executing PHP contained within a Input Format.

To do what you're describing, I'd recommend using the Additional Processing field instead of trying to input PHP into the confirmation message area. See the examples in the Webform handbook: http://drupal.org/handbook/modules/webform/submission-code

shua’s picture

shua commented
Category: bug » support
Status: Needs review » Active

Thanks, i think that the php input option should be removed if it doesn't work any way

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

The PHP input format doesn't exist on all Drupal sites. In fact in Drupal 6 it's disabled by default and you have to enable the PHP Filter module in order for it to be created. Disabling the Input Format on that field would also mean that you couldn't use other filters, such as BBCode or Markdown if you wanted, making the confirmation message inconsistent with other textareas in Drupal. Lastly, you *could* use PHP code if you wanted in that field, but only to generate a confirmation message, not to change the behavior of the submission.

I'm marking this issue as fixed, since this is by design and I don't think it should be changed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.