Problem/Motivation

When updated from 6.2.10 to 6.3.0, Advanced Address element throws an error in the UI as well as a php error.
Note that this only occurs when using Address module version 1.x. When updating to Address 2.x, the integration functions as normal.

Steps to reproduce

  • Install Drupal with webform 6.3.0 and address 1.1.2
  • Create webform
  • Add element: Advanced Address.
  • View the form
  • Select a country from the address field.
  • Error appears in the webpage messages area: "Oops, something went wrong. Check your browser's developer console for more details."
  • PHP error appears in the logs:
    Uncaught PHP Exception Error: "Unknown named parameter $addressLine3" at /path/to/drupal/modules/contrib/webform/src/Plugin/WebformElement/Address.php line 524

Proposed resolution

Add composer conflict to composer.json:

{
    "conflict": {
        "drupal/address": "<2.0.0"
    },
    "suggest": {
        "drupal/address": "In order to support Advanced Address, requires ^2.0"
    }
}

Remaining tasks

Update composer.json

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork webform-3615075

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

shawn dearmond created an issue. See original summary.

liam morland’s picture

Version: 6.3.0 » 6.3.x-dev
Issue tags: +Needs merge request

mukeshaddweb made their first commit to this issue’s fork.

mukeshaddweb’s picture

Status: Active » Needs review
nicholass’s picture

We had this same issue and the patch fixes it.

liam morland’s picture

It looks like the problem was caused by #3520969: Validate US ZIP codes in the Advanced Address element. Perhaps we should just remove the reference to addressLine3. Is it ever there?