Problem/Motivation

In the current dev version, phpstan is reporting the following error in WebformTestAlterHooksHooks.php:

Form alter hook "form_webform_submission_form_alter" first parameter must be passed by reference (&$form). Expected signature: method(&$form, \Drupal\Core\Form\FormStateInterface $form_state[, $form_id])

Proposed resolution

pass the parameter by reference, as directed.

Remaining tasks

make an MR. I'm assigning this to myself since I intend to work on it right away.

Issue fork webform-3614870

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

benstallings created an issue. See original summary.

benstallings’s picture

Assigned: benstallings » Unassigned
Status: Active » Needs review
liam morland’s picture

There are some hook implementations in webform_test_alter_hooks.module that should probably also get this change.