Problem/Motivation

Scanning the dev version of this module with Upgrade Status in Drupal 11.4 produces the following warning about WebformEntityListBuilder.php:

Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.

Upon further investigation, the properties are not used anywhere, so they can just be removed.

Proposed resolution

Remove the unused properties.

Remaining tasks

make an MR. I've assigned the ticket to myself since I intend to work on it right away.

Issue fork webform-3614865

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !912

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
benstallings’s picture

benstallings commented
Title: Use getStorage() instead of a class property in WebformEntityListBuilder » Remove storage class property in WebformEntityListBuilder
Issue summary: View changes
benstallings’s picture

benstallings commented
Title: Remove storage class property in WebformEntityListBuilder » Remove unused storage properties in WebformEntityListBuilder
Issue summary: View changes
benstallings’s picture

benstallings commented
Status: Active » Needs review