Problem/Motivation

Scanning the current dev version of this module with Upgrade Status in Drupal 11.3 produces numerous warnings of the form, "various methods are missing the CacheableMetadata parameter added in Drupal 11.3. Update the signature to include \Drupal\Core\Cache\CacheableMetadata $cacheability as the second parameter."

Proposed resolution

Add the parameter, as optional if possible for backward compatibility, otherwise bumping the compatibility to 11.3.

Remaining tasks

Make an MR. I'm assigning this to myself since I intend to work on it right away.

Issue fork webform-3614713

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !909

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
idebr’s picture

idebr commented
Title: missing CacheableMetadata parameter » Add CacheableMetadata parameter to listBuilder::getDefaultOperations()
Category: Bug report » Task
idebr’s picture

idebr commented
Status: Needs review » Needs work

phpstan reports a few procedural hooks that need to be updated as well, see https://git.drupalcode.org/issue/webform-3614713/-/jobs/11320544 (find: 'CacheableMetadata')

benstallings’s picture

benstallings commented
Status: Needs work » Needs review

Thanks for the feedback, @idebr!

idebr’s picture

idebr commented
Title: Add CacheableMetadata parameter to listBuilder::getDefaultOperations() » Support CacheableMetadata parameter for entity operations
Status: Needs review » Reviewed & tested by the community

All good now!