Problem/Motivation

I know it is not really a bug. But we use webform_encrypt, and the patch to encrypt all webform fields. We work for government, and webform data should be encrypted allways. But then webform_options_limit does not work because it uses a raw query at the form results, and then they won't be decrypted and the element keys will be returned encrypted. So every entry is unique.

Steps to reproduce

* install and setup webform_encrypt
* create a form with radio options, make sure it is encrypted
* add the webform_options_limit handler
* test with some submissions

Proposed resolution

Create an option to choose if the form is encrypted.
If it is not encrypted, just use the raw sql-queries. If the form is encrypted, use the entity queries.

Screenshot of the new setting of encryption of the form

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork webform-3587715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joshahubbers created an issue. See original summary.

liam morland’s picture

Version: 6.2.x-dev » 6.3.x-dev

Webform 6.2.x in nearing EOL and receives only critical bug and security fixes.

joshahubbers’s picture

@liam morland: I understand, but we are currently on 6.2. I will port this to 6.3 when it is finished and we start upgrading to Drupal 11.

joshahubbers’s picture

StatusFileSize
new23.34 KB

After review we decided it would be better to add the option to use the entity query so the module can use the more efficient raw sql query when a form is not encrypted.

The new option to indicate a webform is encrypted

joshahubbers’s picture

@liam morland: I added a mr to the 6.3.x branch which is exactly the same as the 6.2.x mr. Is that ok?

joshahubbers’s picture

Issue summary: View changes
Status: Active » Needs review

liam morland’s picture

That is fine. You could also just change which branch is targeted by the MR.