Closed (fixed)
Project:
Webform
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2008 at 22:29 UTC
Updated:
23 Jan 2009 at 09:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
quicksketchThanks. This could take a short while to review, but I'll make sure to do it before the patch gets stale. We can't apply to just one branch of Webform however. Could you resolve the conflicts when this patch is applied to Drupal 5?
Comment #2
eMPee584 commenteduuhh.. well maybe porting the bug fixes is sufficient for the 5.x branch? i'll check this l8r..
Comment #3
quicksketchIn order to maintain both versions of the module, they need to be as consistent as possible in every way (*especially* spacing and code style consistencies). Otherwise every patch that comes up takes forever to apply to both versions.
Comment #4
eMPee584 commentedok here's the 5-x version hope i didn't miss anything.
Comment #5
eMPee584 commentedi am not supposed to rebase this, am i?
Comment #6
quicksketchOkay... finally committed. Thanks for the general code style fixes.
However. Please do not EVER submit another issue to any of my project that deal with switching double quotes to single quotes. I don't care. Regarding the use of drupal_* functions such as drupal_strtolower() or drupal_substr(), these are completely unnecessary in situations where we already know what the string values are (since they're in code originally). I don't have statistics, but I'd bet a single call to drupal_substr() negates a million double quotes. Have you looked at the code for that function? I also cleaned up a dozen misuses of update_sql(), which cannot take parameters so this patch would have broken all update paths.
I'm thankful for the patch, but really this could have totaled 300 lines instead of 3000. I mostly committed it because I know it was a lot of work for you to do both of these patches. So thanks again. Please chill out.
Comment #7
eMPee584 commentedok quicksketch thx for handling it sanefully. Also i got your points, guess you're right, sorry about possible WOT ;=]