Currently when you don't set a default value in a webform time component you get 2 dropdowns for hour/minute that are set to the empty values "Hour" and "Minute".
This issue wants to add an option to change those "global defaults" so that it is set to a specific value if there is no default value.
The need for this change was more apparent in the past when webform set 0 as default value for the minute field. However in later versions the minute field was also left empty.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | webform-time_global_default_values-2810913-5.patch | 2.46 KB | paulvandenburg |
Comments
Comment #2
ruudvanoijen commentedComment #3
ruudvanoijen commentedComment #4
paulvandenburg commentedIt would be better to follow Drupal standards by prefixing variable names with the module name.
The description could also be more descriptive, because I currently need to look at the patch to see what is requested here.
Also it would be nice to add these variables to a settings page in the web interface.
Comment #5
paulvandenburg commentedThis patch fixes the work I mentioned before.
Changes the variables to follow standards.
Added these variables to the webform settings.
However I'm still not entirely convinced this is a valuable addition. On the other hand the impact is very minimal and unless you set these new values nothing is changed. Since you can already set the default value in the component's settings.
But if you are in need of a global default value for the time component this does do the trick.
Comment #6
paulvandenburg commentedAnd a version of that patch which applies to 4.16.
Comment #7
johankleene commentedReviewed. Works as explained.
Comment #8
liam morlandI agree with #5. I don't think this is likely to be valuable to many people and it adds another configuration. Unless there is substation support for this feature, I will close it "won't fix".
Comment #9
liam morland