Currently the 'edit own webforms' and 'edit webforms' allow user to delete the content. It be nicer if it would be like core 'delete own webforms' and 'delete webforms'.

CommentFileSizeAuthor
#10 webform_permissions_refresh.patch13.31 KBquicksketch

Comments

quicksketch’s picture

I agree, this would be a good addition, if nothing else than to ensure consistency across different content types.

quicksketch’s picture

I was going to include this in the next release, but I've realized a few changes will be necessary:

- Create "delete any webforms"
- Create "delete own webforms"
- Rename "edit webforms" to "edit any webforms"

Renaming is sort of the big one, since it'll require an update function. Let's wait until after the 2.1 release to tackle a database update.

quicksketch’s picture

In addition, we might also split up "edit own webform submissions" and "edit webform submissions".

drupalicasso’s picture

Is there any way I can delete a webform ( not just clear the submissions on a webform) ?
Trying for the last few hours to get webform working and have now created a few webforms, during testing and I want to delete those and keep the one i need.
Need to keep the content less messy.
Many thanks

quicksketch’s picture

You can delete any Webform by clicking the "Edit" tab and then hitting the "Delete" button at the bottom of the form, just like any other node in Webform. You can also visit admin/content/node and bulk delete multiple nodes at once.

drupalicasso’s picture

Thanks quicksketch,
Not sure how i missed it.

quicksketch’s picture

Version: 6.x-2.0-beta6 »

Let's move this to the 3.x branch, since 2.x is no longer being developed. Then we don't have to have include a change to the Drupal 5 branch, which doesn't have these permissions anyway.

quicksketch’s picture

Title: Add permission 'delete webform', » Add separate "delete" permissions, add "any" to distiguish from "own" permissions

I've marked #318036: Add a delete own submission permission as duplicate.

#510256: Allow webforms on any content type had the convenient side-effect of doing this renaming for us. However there are still a few permissions that need to be updated.

In summary we need to do the following:

- Delete the permissions for 'create webforms', 'edit webforms', and 'edit own webforms' (these are replaced with node module's normal access controls)
- Rename 'access webform results' to 'access all webform results'
- Rename 'edit webform submissions' to 'edit all webform submissions'
- Add 'delete own webform submissions'
- Add 'delete all webform submissions'

quicksketch’s picture

While we're at it, I think removing the 'clear webform results' would be a good idea too, considering it's the same (just less tedious) as 'delete all webform submissions'.

quicksketch’s picture

Status: Active » Fixed
StatusFileSize
new13.31 KB

I've committed this patch which clarifies and upgrades the permissions with new names. We now have:

- access all webform results
- access own webform results
- access own webform submissions
- delete all webform submissions
- delete own webform submissions
- edit all webform submissions
- edit own webform submissions

All in all I think this is much more clear (though not perfect). D7 can't get here soon enough to let use put descriptions on these things. :P

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.