Rename upload file does not work in edit [#2606370]

Comment #1

2 November 2015 at 13:38

was.uthm created an issue. See original summary.

Log in or register to post comments

Comment #2

danchadwick commented 2 November 2015 at 13:46

Category:	Bug report	» Feature request
Issue tags:	-rename upload

I don't think it should unless the file is re-uploaded. Can you explain your use case?

Log in or register to post comments

Comment #3

waluyo.umam commented 2 November 2015 at 22:50

This feature is important to maintain the consistency of the filename.

- A user submitted a paper file then file renamed according to the rename rule, defined by the tokens.
- The user made a revision to the file and sent it to the coordinator (who has access to view results) to replace the old file with the new version.
- The coordinator opened the submission. In this edit submission, the coordinator removed the previous uploaded file and uploaded the new version. This new uploaded file will not be renamed according to the rename rule, but in original name. It is expected the rename rule also applicable in editing mode, not only in new submission.

Log in or register to post comments

Comment #4

Tsjippy commented 8 February 2016 at 16:05

I have the same issue.

If I upload a file to an already submitted form, the file does not get renamed

Log in or register to post comments

Comment #5

waluyo.umam commented 4 March 2016 at 15:05

Hello,
Is there any patch that can do this feature.

Log in or register to post comments

Comment #6

Jose Casal commented 9 May 2016 at 16:12

Same problem here. File is not renamed after editing a submission.

Log in or register to post comments

Comment #7

brt commented 26 September 2016 at 09:18

Another use case for this problem:
- A form submission is made without a file attachment
- Afterwards a file is attached to the existing submission
- The uploaded file is not renamed

Log in or register to post comments

Comment #8

brt commented 26 September 2016 at 10:38

I had a look at the code.
On line 1289 in webform.module this behaviour is explicitly defined. It seem to be a feature and not a bug.
Could someone please explain why we need this?

    // Only rename files if this is the first time the submission is being saved as finished.
    if ($submission->is_draft || (isset($old_submission) && !$old_submission->is_draft)) {
      $renameable = array();
    }