I noticed that $form['#is_draft'] is set but not referenced anywhere. The same information can be obtained either from the $form['#submission'], $form['details']['finished']['#value'] or from $form_state['values']['details']['finished'].
Until recently, it was inconsistently set, too.
I propose to remove it, absent objections. The only risk I see is if another contributed module relies on it, but I suspect that is rather unlikely, especially since it wasn't set consistently until recently.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | webform-hash_draft_unused-2296563-4.patch | 844 bytes | danchadwick |
Comments
Comment #1
danchadwick commentedI've decided to not do this. In webform_client_form, the $is_draft parameter is used only to set $form['#is_draft'], and it is never set true unless the submission is a draft. The code to pass the parameter and set $form['#is_draft] is not needed. Alas there is an optional parameter after $is_draft, so removing it would change the API.
The Drupal 8 version should consider this code clean-up, if this part of the D7 code makes it to D8. However, given that we are actively applying 7.x-4.x patches to the 8.x branch, I hesitate to commit this to 8.x for fear of making that work harder.
Minor issue, about which I've already made too much.
Comment #2
danchadwick commented7.x-4.x -- won't fix.
8.x - active.
Comment #3
danchadwick commentedComment #5
danchadwick commentedCommitted to 8.x.