Over in #1140026: Excel-native exporter, fixing new line and UTF-8 importing problems, I'm working on creating a new Excel-native exporter. Because it's only compatible with Excel 2007 and higher, this probably means we'll have a 3rd exporter (Excel new, Excel old, and Delimited). I think it would make sense to split off our classes into separate files. While we're at it, some adequate documentation on the webform_exporter base class would be a good idea too.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | webform_separate_exporters.patch | 14.7 KB | quicksketch |
Comments
Comment #1
quicksketchHere's a patch which does the moving, adds docs to the webform_exporter class, and preps us for #1140026: Excel-native exporter, fixing new line and UTF-8 importing problems by creating a new post_process() method.
Comment #2
quicksketchCommitted to 7.x-4.x.
Comment #4
ianthomas_ukThis is an API change (webform_exporter_excel has been renamed to webform_exporter_excel_delimited) but has been missed off the release notes for 7.x-4.0-alpha10
Release notes: https://drupal.org/node/2061069
alpha10 commit history: http://drupalcode.org/project/webform.git/shortlog/e1875177c5b123fcaef32...
Comment #5
quicksketchWe have this set of changes partially documented in the upgrading documentation: https://drupal.org/node/1609324#webform-exporters, but you're right that we don't mention the renaming of the classes, only the way constructors are used. We should update the upgrading docs, and include a link to the upgrade information from the release notes.
Comment #6
quicksketchActually, this was caused by #1140026: Excel-native exporter, fixing new line and UTF-8 importing problems, not this issue itself, but regardless the change was made in alpha10.
Comment #7
quicksketchI documented the renaming of the class at https://drupal.org/node/1609324#webform-excel-class and updated the release notes with a mention of the upgrade docs: