Hello,
I was wondering why in webform.module in the function webform_menu(), the first item ($items['admin/content/webform']) has 'type' => MENU_NORMAL_ITEM and not MENU_LOCAL_TASK ?

Thanks

CommentFileSizeAuthor
#2 1197532.patch445 bytesamateescu

Comments

quicksketch’s picture

quicksketch
he/him
commented
Title: function webform_menu() » Webform admin/content/webform page should be MENU_LOCAL_TASK in Drupal 7
Category: feature » bug

Thanks, I hadn't noticed this inconsistency with Drupal 7. In Drupal 6 it made much more sense to be a MENU_NORMAL_ITEM, looks like it just was never changed.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 1197532.patch445 bytes

And here's a quick patch for this.

quicksketch’s picture

quicksketch
he/him
commented
Priority: Normal » Minor
Status: Needs review » Fixed

Committed. Thanks for the report and patch!

amateescu’s picture

amateescu commented
Status: Fixed » Reviewed & tested by the community

I don't see this one in the commit log http://drupalcode.org/project/webform.git/shortlog/refs/heads/master
Maybe you forgot to push?

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

Yep, it's pushed now.

anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
commented

Great ! And thanks for the help on this one : http://drupal.org/node/1230784

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.