Hi,

This little patch to :
- propose a corrected behaviour for Watcher when comments are disabled for current node : no select, "only updates" as default
- "Yes I'm sure." string was not translatable

I hope it helps.

CommentFileSizeAuthor
#6 watcher-1.4.patch2.58 KBpomliane
watcher.patch2.51 KBpomliane

Comments

solipsist’s picture

solipsist commented

Thanks. It doesn't seem like this patch shows a different help text when only node updates are provided. It's confusing to users if the text above the field where they enter their email address mentions that they can subscribe to updates and new comments and there's no option to choose or information that only updates are possible.

pomliane’s picture

pomliane commented
Assigned: Unassigned » pomliane
Status: Needs review » Needs work

Thank you for your reply.

As you have noticed, the proposed patch replaces the whole "What to watch for" with... nothing and I thought it would be quite fine. :)
Right or wrong, here is the reasoning:
A. Comments are enabled for the node
1. Title of the watcher block :"Watch [title of the node]
2. Watcher help text "Enter your email address below to start watching %title. The form will remember the email you enter until next time. Once you submit the form, a confirmation message will be sent to the email address entered..."
3. Email address field
4. Selector : updates and comments / comments only / updates only
5. Selector help text "Choose to be informed about new comments, updates (this post being changed) or both."

B. Comments are disabled for the node
1. Title of the watcher block :"Watch [title of the node]
2. Watcher help text "Enter your email address below to start watching %title. The form will remember the email you enter until next time. Once you submit the form, a confirmation message will be sent to the email address entered..."
3. Email address field
4. No selector
5. No selector help text

Should the help text you're writing about be placed in 5.?

Should it be something like "Be informed about updates (this post being changed)." ?

Thanks in advance.

pomliane’s picture

pomliane commented
Status: Needs work » Needs review
pomliane’s picture

pomliane commented

May I... Bump?

solipsist’s picture

solipsist commented

Ok, thanks. I'll get back to you in a bit.

pomliane’s picture

pomliane commented
Version: 6.x-1.3 » 6.x-1.4
StatusFileSize
new watcher-1.4.patch2.58 KB

Patch updated to 6.x-1.4.

pomliane’s picture

pomliane commented

Hi,
Is there any chance this patch gets reviewed?

pomliane’s picture

pomliane commented
Assigned: pomliane » Unassigned
d.novikov’s picture

d.novikov commented
Status: Needs review » Closed (fixed)

Patch is applied and commited. Thank you, @Pomliane.

pomliane’s picture

pomliane commented

Thanks.
Very happy to see this project has found its maintainer! :)