I don't know why you use so much the important rule in the watcher.css but it makes styling more complicate. Please remove !important, if not really needed.

CommentFileSizeAuthor
#7 watcher-css_remove_important-577968-7.patch2.38 KBtostinni
#3 wachter-css-1.patch3.75 KBjix_

Comments

askibinski’s picture

askibinski commented

I agree.

Using !important is poor css design and should be avoided. You will make a lot of themers happy :)

solipsist’s picture

solipsist commented

You can make me happy by making a patch. I am well aware of the issue but it's not something I can prioritize highly, so a patch would be help a lot.

jix_’s picture

jix_ commented
Status: Active » Needs review
StatusFileSize
new wachter-css-1.patch3.75 KB

Attached a patch. I also took the liberty of removing some whitespace and the @CHARSET declaration, which don't seem to be common to use in Drupal.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thank you for the patch!

onyxnz’s picture

onyxnz commented

This line 77 is wrong in pre-patched and patched:

.watcher_node_watched

should be :
background-image: url(../images/watch.gif) no-repeat

Otherwise you can click twice the under-node link and get a div full of eyeballs :D

pomliane’s picture

pomliane commented
Status: Reviewed & tested by the community » Needs work
tostinni’s picture

tostinni commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new watcher-css_remove_important-577968-7.patch2.38 KB

Here is an updated patch for Drupal 7.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs review » Reviewed & tested by the community

Patch applies successfully and removes the !importants from the CSS. Marking RTBC.