Closed (fixed)
Project:
Warn Me!
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2009 at 16:54 UTC
Updated:
31 Dec 2009 at 10:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
sinasalek commentedSome improvment
Comment #2
lyricnz commentedThese seem like good ideas. Please provide the second version as a patch for review. Thanks!
Comment #3
lyricnz commentedHi sinasalek. I don't understand why new code is needed to:
That behaviour will naturally happen if you add settings to $conf and use variable_get() to check for it.
Also, I've simplified the conditional logic a little, removed tab characters per coding standards, etc. Please review.
Comment #4
lyricnz commentedReroll with changes from #660742: WSOD when disabling devel_themer module.
Comment #5
sinasalek commentedThanks lyricnz, i don't see where $mode comes from in the last patch. I used the following code to set $mode
According to your previous comment something like this should also work ?
Comment #6
lyricnz commentedsinasalek: the reason that you don't see the line that sets $mode in the patch is that the existing code, which does:
hasn't changed, so isn't included in the patch.
Comment #7
sinasalek commentedI update my installation to the latest dev and applied #4. I can confirm that it words. Thanks
Comment #8
lyricnz commentedApplied http://drupal.org/cvs?commit=303376
Thanks!