Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#21 votingapi-8.x-3.0-beta5-d11-compatibility.patch12.48 KBowilliwo
#20 votingapi-8.x-3.0-beta5-d11-compatibility.patch10.94 KBowilliwo
#17 d11-votingapi.patch1.3 KBnaim belkaied
#2 votingapi.3.x-dev.rector.patch395 bytesproject update bot

Issue fork votingapi-3451390

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new votingapi.3.x-dev.rector.patch395 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !14

tr’s picture

tr commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

ao5357 made their first commit to this issue’s fork.

ao5357’s picture

ao5357 commented
Status: Closed (won't fix) » Needs review

It looks like the rector patch only added ^11 to the info yaml file. It's unclear if other Drupal 11 compatibility fixes are required against 3.x, but it's certainly worthwhile to support Drupal 11. I've manually applied the patch to the MR for ease of composer-ing.

ao5357 opened merge request !28

tr’s picture

tr commented
Status: Needs review » Closed (won't fix)
ao5357’s picture

ao5357 commented
Status: Closed (won't fix) » Needs review

tr can you either link to the other issue where votingapi will be updated to be compatible with the current version of Drupal or explain why this module won't be updated?

tr’s picture

tr commented

It already is compatible and working in D11 on the 4.0.x branch. Please leave this issue closed.

8.x-3.x is for Drupal ^9.2 || ^10
4.0.x is for Drupal ~10.3 || ^11

tr’s picture

tr commented
Status: Needs review » Closed (won't fix)
ivnish’s picture

ivnish
he/him
commented

Hi @TR !

Is there a plan to 4.0 alpha or beta?

tr’s picture

tr commented

Yes, I am working on votingapi, and fivestar and votingapi_widgets (which depend on votingapi), to get a stable release for all. The big blocker is the structure of the Vote and VoteResult entities need to be changed, and that involves a potentially disruptive hook_update and update tests. These are changes that can only be made in a new major release, which is why I opened the 4.0.x branch, and why I don't want to have a 4.0.0 release without finishing those changes.

ivnish’s picture

ivnish
he/him
commented

This may take a long time. What should people do who need to upgrade to Drupal 11 now? Use the dev version? Is it ready for production?

tr’s picture

tr commented

All I can promise is that I am running 4.0.x-dev on a D11 site and I haven't had problems with it. The best way to find problems is to actually use it - there are probably no more than a handful of sites that have tried it so far. I am making progress, but like you said it's probably going to take a while especially with no community contribution.

ivnish’s picture

ivnish
he/him
commented

I can help with contribute, but we need a plan for 4.0 release

naim belkaied’s picture

naim belkaied commented
StatusFileSize
new d11-votingapi.patch1.3 KB

This is a complete patch that addresses upgrade status messages for Drupal 11.

samitk’s picture

samitk commented

Hello everyone,

I am looking for clarity on the Voting API module's (https://www.drupal.org/project/votingapi) Drupal 11 roadmap. We're evaluating it for a D11 project and noticed there's no stable D11-compatible release; the automated compatibility issue (#3451390) was closed as "won't fix."

Several modules that depend on Voting API (like Rate, Voting API Reaction, etc) have already declared D11 support, so the underlying API may already work.

A few questions for the maintainers or anyone with insight:

• Is there a plan for a D11-compatible stable release?
• What's blocking it - deprecated API calls, architectural issues, or just maintainer bandwidth?

Thanks
Samit K

charginghawk’s picture

charginghawk commented
Related issues: +#3396329: Stable or beta 4.x D11-compatible release

Linking #3396329: Stable or beta 4.x D11-compatible release since it's open and gets directly to the roadmap question.

owilliwo’s picture

owilliwo
Location Montreal
commented
StatusFileSize
new votingapi-8.x-3.0-beta5-d11-compatibility.patch10.94 KB

Hey there !
So, I need to migrate my project to Drupal 11, and I cannot wait for version 4 to get stable (maybe I could get a look into that later).

That said, I'be been working on a patch for the 8.x-3.0-beta5, using Claude Sonnet 4.6 agent and the scan from the Upgrade Status module (4.3.9).

Here is the result.

owilliwo’s picture

owilliwo
Location Montreal
commented
StatusFileSize
new votingapi-8.x-3.0-beta5-d11-compatibility.patch12.48 KB

OK, I forgot to add a newly created class in the patch file: Drupal\votingapi\Attribute\VoteResultFunction
Here is a new version of the patch.

And a resume of what's done:

  • votingapi.info.yml — updated core_version_requirement to include ^11
  • src/Attribute/VoteResultFunction.php — new PHP 8 attribute class
  • src/VoteResultFunctionManager.php — updated to use attribute + annotation dual discovery
  • src/Plugin/VoteResultFunction/Average|Count|Sum.php — added #[VoteResultFunction(...)] attributes
  • src/Form/SettingsForm.php — updated constructor with TypedConfigManagerInterface, new self()
  • src/Form/VoteDeleteConfirm|VoteTypeDeleteConfirm.php — new self()
  • src/VoteTypeForm.php — new self(), save(): int, return $status
  • src/VoteStorage.php + VoteStorageInterface.php — : void return types on deleteUserVotes and deleteVotesForDeletedEntity
  • drush.services.yml — removed unused arguments
  • modules/votingapi_tokens/votingapi_tokens.info.yml — ^11 added